Branch: refs/heads/master Home: https://github.com/jenkinsci/phabricator-plugin Commit: a93675685baa958d77915b8116fa2edeca6b3f49 https://github.com/jenkinsci/phabricator-plugin/commit/a93675685baa958d77915b8116fa2edeca6b3f49 Author: Jerry Xie <je...@uber.com> Date: 2015-06-28 (Sun, 28 Jun 2015)
Changed paths: M src/main/java/com/uber/jenkins/phabricator/PhabricatorNotifier.java M src/main/java/com/uber/jenkins/phabricator/uberalls/UberallsClient.java Log Message: ----------- Remove environment dependency from UberallsClient Commit: 3f9c36a74a91b60905474da1e9ca15e20a210b10 https://github.com/jenkinsci/phabricator-plugin/commit/3f9c36a74a91b60905474da1e9ca15e20a210b10 Author: Jerry Xie <je...@uber.com> Date: 2015-06-28 (Sun, 28 Jun 2015) Changed paths: M src/main/java/com/uber/jenkins/phabricator/PhabricatorNotifier.java M src/main/java/com/uber/jenkins/phabricator/uberalls/UberallsClient.java Log Message: ----------- Plum down the logger Commit: c9ca27b95710358fed14ae5665c2c618d4e5d4e1 https://github.com/jenkinsci/phabricator-plugin/commit/c9ca27b95710358fed14ae5665c2c618d4e5d4e1 Author: Aiden Scandella <s...@ndella.com> Date: 2015-06-28 (Sun, 28 Jun 2015) Changed paths: M phabricator-plugin.iml M pom.xml M src/main/java/com/uber/jenkins/phabricator/PhabricatorBuildWrapper.java M src/main/java/com/uber/jenkins/phabricator/PhabricatorNotifier.java M src/main/java/com/uber/jenkins/phabricator/conduit/Differential.java A src/main/java/com/uber/jenkins/phabricator/conduit/DifferentialClient.java A src/test/java/com/uber/jenkins/phabricator/conduit/DifferentialTest.java A src/test/resources/com/uber/jenkins/phabricator/conduit/validDifferentialQueryResponse.json Log Message: ----------- Break Differential up to make it testable Previously was mixing concerns with both talking to arcanist and presenting results. By breaking out a DifferentialClient that I can easily mock, we can test the core functionality without a ton of boilerplate. Commit: de0d743a08806bc0512c88ffd3faa3c43da7895c https://github.com/jenkinsci/phabricator-plugin/commit/de0d743a08806bc0512c88ffd3faa3c43da7895c Author: Aiden Scandella <s...@ndella.com> Date: 2015-06-28 (Sun, 28 Jun 2015) Changed paths: M src/main/java/com/uber/jenkins/phabricator/conduit/DifferentialClient.java Log Message: ----------- fix argument ordering Commit: 69701e8b300db09694b77be1d55395345d67de6c https://github.com/jenkinsci/phabricator-plugin/commit/69701e8b300db09694b77be1d55395345d67de6c Author: Aiden Scandella <s...@ndella.com> Date: 2015-06-28 (Sun, 28 Jun 2015) Changed paths: M pom.xml Log Message: ----------- Also output HTML coverage reports for hoomans Commit: 6d9f26662f8a5e1dd0aeb589b25a7318f64b440b https://github.com/jenkinsci/phabricator-plugin/commit/6d9f26662f8a5e1dd0aeb589b25a7318f64b440b Author: jjx <je...@uber.com> Date: 2015-06-28 (Sun, 28 Jun 2015) Changed paths: M src/main/java/com/uber/jenkins/phabricator/PhabricatorNotifier.java M src/main/java/com/uber/jenkins/phabricator/uberalls/UberallsClient.java Log Message: ----------- Merge pull request #40 from uber/remove_env_uberallsclient Remove env dependency from uberallsclient Commit: 1762407c198b11cfcf19262e3e918c00d11ce88b https://github.com/jenkinsci/phabricator-plugin/commit/1762407c198b11cfcf19262e3e918c00d11ce88b Author: Aiden Scandella <s...@ndella.com> Date: 2015-06-28 (Sun, 28 Jun 2015) Changed paths: M src/main/java/com/uber/jenkins/phabricator/PhabricatorBuildWrapper.java M src/main/java/com/uber/jenkins/phabricator/PhabricatorNotifier.java M src/main/java/com/uber/jenkins/phabricator/conduit/Differential.java M src/main/java/com/uber/jenkins/phabricator/conduit/DifferentialClient.java M src/test/java/com/uber/jenkins/phabricator/conduit/DifferentialTest.java Log Message: ----------- address feedback Commit: 2bf96fc0cfbab97ffb43482c699e0968c9e4740f https://github.com/jenkinsci/phabricator-plugin/commit/2bf96fc0cfbab97ffb43482c699e0968c9e4740f Author: Aiden Scandella <s...@ndella.com> Date: 2015-06-28 (Sun, 28 Jun 2015) Changed paths: M src/test/java/com/uber/jenkins/phabricator/conduit/DifferentialTest.java Log Message: ----------- Address review feedback Commit: 70aaad4039a201286b2ed0c5273e72e8ccd40431 https://github.com/jenkinsci/phabricator-plugin/commit/70aaad4039a201286b2ed0c5273e72e8ccd40431 Author: Aiden Scandella <s...@ndella.com> Date: 2015-06-28 (Sun, 28 Jun 2015) Changed paths: M src/main/java/com/uber/jenkins/phabricator/conduit/Differential.java M src/test/java/com/uber/jenkins/phabricator/conduit/DifferentialTest.java Log Message: ----------- remove newline and stacktrace Commit: f45768bdfd0fb112cc9afe6edb5623dbc75100cd https://github.com/jenkinsci/phabricator-plugin/commit/f45768bdfd0fb112cc9afe6edb5623dbc75100cd Author: Aiden Scandella <s...@ndella.com> Date: 2015-06-28 (Sun, 28 Jun 2015) Changed paths: M src/main/java/com/uber/jenkins/phabricator/conduit/DifferentialClient.java Log Message: ----------- Fix ordering Commit: 905fce4882c5dbf675614a50013929ff5ff4181b https://github.com/jenkinsci/phabricator-plugin/commit/905fce4882c5dbf675614a50013929ff5ff4181b Author: Aiden Scandella <s...@ndella.com> Date: 2015-06-29 (Mon, 29 Jun 2015) Changed paths: M phabricator-plugin.iml M pom.xml M src/main/java/com/uber/jenkins/phabricator/PhabricatorBuildWrapper.java M src/main/java/com/uber/jenkins/phabricator/PhabricatorNotifier.java M src/main/java/com/uber/jenkins/phabricator/conduit/Differential.java A src/main/java/com/uber/jenkins/phabricator/conduit/DifferentialClient.java A src/test/java/com/uber/jenkins/phabricator/conduit/DifferentialTest.java A src/test/resources/com/uber/jenkins/phabricator/conduit/validDifferentialQueryResponse.json Log Message: ----------- Merge pull request #38 from uber/more-tests Break Differential up to make it testable Compare: https://github.com/jenkinsci/phabricator-plugin/compare/07efa7283f51...905fce4882c5 -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.