Branch: refs/heads/more-tests Home: https://github.com/jenkinsci/phabricator-plugin Commit: ffa587a463606cbf4e7bc43583d55acae689ecff https://github.com/jenkinsci/phabricator-plugin/commit/ffa587a463606cbf4e7bc43583d55acae689ecff Author: Aiden Scandella <s...@ndella.com> Date: 2015-06-27 (Sat, 27 Jun 2015)
Changed paths: M phabricator-plugin.iml M pom.xml M src/main/java/com/uber/jenkins/phabricator/PhabricatorBuildWrapper.java M src/main/java/com/uber/jenkins/phabricator/PhabricatorNotifier.java M src/main/java/com/uber/jenkins/phabricator/conduit/Differential.java A src/main/java/com/uber/jenkins/phabricator/conduit/DifferentialClient.java A src/test/java/com/uber/jenkins/phabricator/conduit/DifferentialTest.java A src/test/resources/com/uber/jenkins/phabricator/conduit/validDifferentialQueryResponse.json Log Message: ----------- Break Differential up to make it testable Previously was mixing concerns with both talking to arcanist and presenting results. By breaking out a DifferentialClient that I can easily mock, we can test the core functionality without a ton of boilerplate. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.