Branch: refs/heads/master
Home: https://github.com/jenkinsci/git-plugin
Commit: c23ac82355f96e91612c1e37c4f798f511ad9505
https://github.com/jenkinsci/git-plugin/commit/c23ac82355f96e91612c1e37c4f798f511ad9505
Author: Mark Waite <mark.earl.wa...@gmail.com>
Date: 2015-05-21 (Thu, 21 May 2015)
Changed paths:
M src/main/java/hudson/plugins/git/util/BuildData.java
Log Message:
-----------
Allow getLastBuild(sha1) fast evaluation to actually find builds
The previous code attempted a fast evaluation but had used two
different object types in the equals comparison. Since objects of
different types are rarely equal, the "fast check" would never have
found a build.
Detected by findbugs
Commit: ae89fab254b7d58898f800e92626c0ad7777a56e
https://github.com/jenkinsci/git-plugin/commit/ae89fab254b7d58898f800e92626c0ad7777a56e
Author: Mark Waite <mark.earl.wa...@gmail.com>
Date: 2015-05-21 (Thu, 21 May 2015)
Changed paths:
M src/main/java/hudson/plugins/git/browser/RhodeCode.java
Log Message:
-----------
Guard against NPE in RhodeCode browser
Found by findbugs through recently added annotation of return value of
GitChangeSet.getParentCommit()
Commit: d34a709dd24a38cc74267a43efd9770075798348
https://github.com/jenkinsci/git-plugin/commit/d34a709dd24a38cc74267a43efd9770075798348
Author: Mark Waite <mark.earl.wa...@gmail.com>
Date: 2015-05-21 (Thu, 21 May 2015)
Changed paths:
M src/main/java/hudson/plugins/git/util/BuildData.java
Log Message:
-----------
Use separate null pointer check, don't confuse findbugs
Using a separate store of a string (in this case) resolves a findbugs
warning without making the code significantly harder to read
Commit: d51465ea7e163302a218876a62d199776533fc21
https://github.com/jenkinsci/git-plugin/commit/d51465ea7e163302a218876a62d199776533fc21
Author: Mark Waite <mark.earl.wa...@gmail.com>
Date: 2015-05-21 (Thu, 21 May 2015)
Changed paths:
M src/main/java/hudson/plugins/git/GitTagAction.java
Log Message:
-----------
Fix trivial spelling error in GitTagAction exception message
Commit: f369f2e3ab41b4231ff97b90aa9105eb282084f2
https://github.com/jenkinsci/git-plugin/commit/f369f2e3ab41b4231ff97b90aa9105eb282084f2
Author: Mark Waite <mark.earl.wa...@gmail.com>
Date: 2015-05-21 (Thu, 21 May 2015)
Changed paths:
M src/test/java/hudson/plugins/git/GitSCMTest.java
Log Message:
-----------
Check BuildData.getLastBuild and BuildData.hasBeenBuilt
Improved assertion failure messages.
Initially used this test to explore the behavior of the getLastBuild
fast check. Concluded that while the fast check was never succeeding,
it was also not causing incorrect results to be returned by the
getLastBuild(sha1) method.
Intentionally left the few extra assertions in the code rather than
delete them, since they are low cost to execute and might detect a
problem in the future.
Compare:
https://github.com/jenkinsci/git-plugin/compare/83fe7252c075...f369f2e3ab41
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
