Branch: refs/heads/master
Home: https://github.com/jenkinsci/ssh-agent-plugin
Commit: c1d215f7b690b3389015fb185b7ba91f27c5c185
https://github.com/jenkinsci/ssh-agent-plugin/commit/c1d215f7b690b3389015fb185b7ba91f27c5c185
Author: Kohsuke Kawaguchi <k...@kohsuke.org>
Date: 2015-04-20 (Mon, 20 Apr 2015)
Changed paths:
M src/main/java/com/cloudbees/jenkins/plugins/sshagent/jna/AgentServer.java
Log Message:
-----------
Don't prevent JVMs from terminating.
In investigating CloudBees DEV@cloud OPEs that hang and doesn't
reconnect, I noticed that thread dumps show a number of SSH agents
threads at the accept call like the following:
"Thread-7" prio=10 tid=0x00007f6d30113000 nid=0x1f34 runnable
[0x00007f6d54625000]
java.lang.Thread.State: RUNNABLE
at com.kenai.jffi.Foreign.invokeN3O2(Native Method)
at com.kenai.jffi.Invoker.invokeN3(Invoker.java:1092)
at jnr.unixsocket.Native$LibC$jnr$ffi$0.accept(Unknown Source)
at jnr.unixsocket.Native.accept(Native.java:91)
at
jnr.unixsocket.UnixServerSocketChannel.accept(UnixServerSocketChannel.java:56)
at
com.cloudbees.jenkins.plugins.sshagent.jna.AgentServer$1.run(AgentServer.java:77)
I need to find out why CLI main threads aren't doing System.exit(), but these
agent threads also shouldn't keep JVM alive.
This change marks them as daemon threads, so that threads lying around won't
prevent JVMs from getting terminated.
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
