Branch: refs/heads/master
  Home:   https://github.com/jenkinsci/envinject-plugin
  Commit: 980b0487d13c12583e3345a6f9d0dd88b8d693fe
      
https://github.com/jenkinsci/envinject-plugin/commit/980b0487d13c12583e3345a6f9d0dd88b8d693fe
  Author: Oliver Gondža <[email protected]>
  Date:   2015-01-25 (Sun, 25 Jan 2015)

  Changed paths:
    M 
src/test/java/org/jenkinsci/plugins/envinject/sevice/PropertiesLoaderTest.java

  Log Message:
  -----------
  Do not abuse org.mockito.Matchers.any to create test stubs.
   
getEnvVarsPreviousStepsWithEnvInjectAction(org.jenkinsci.plugins.envinject.sevice.EnvInjectVariableGetterTest)
  Time elapsed: 0.097 sec  <<< ERROR!
  org.mockito.exceptions.misusing.InvalidUseOfMatchersException:
  Misplaced argument matcher detected here:
  -> at 
org.jenkinsci.plugins.envinject.sevice.PropertiesLoaderTest.notExistFile(PropertiesLoaderTest.java:30)
   You cannot use argument matchers outside of verification or stubbing.
  Examples of correct usage of argument matchers:
      when(mock.get(anyInt())).thenReturn(null);
      doThrow(new RuntimeException()).when(mock).someVoidMethod(anyObject());
      verify(mock).someMethod(contains("foo"))
   Also, this error might show up because you use argument matchers with 
methods that cannot be mocked.
  Following methods *cannot* be stubbed/verified: 
final/private/equals()/hashCode().
           at 
org.jenkinsci.plugins.envinject.sevice.EnvInjectVariableGetterTest.setUp(EnvInjectVariableGetterTest.java:30)
          ...


  Commit: de93818b4007a985744b7b1a2a7150ab66321679
      
https://github.com/jenkinsci/envinject-plugin/commit/de93818b4007a985744b7b1a2a7150ab66321679
  Author: Oliver Gondža <[email protected]>
  Date:   2015-01-25 (Sun, 25 Jan 2015)

  Changed paths:
    M src/test/java/org/jenkinsci/plugins/envinject/EnvInjectEnvVarsEmpty.java
    M 
src/test/java/org/jenkinsci/plugins/envinject/sevice/PropertiesGetterTest.java
    M 
src/test/java/org/jenkinsci/plugins/envinject/sevice/PropertiesLoaderTest.java

  Log Message:
  -----------
  Better deffect localization


Compare: 
https://github.com/jenkinsci/envinject-plugin/compare/e5134f6e60db...de93818b4007

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to