Branch: refs/heads/master Home: https://github.com/jenkinsci/gerrit-trigger-plugin Commit: 341c001bedb163a60b1db3967a4a72810f516417 https://github.com/jenkinsci/gerrit-trigger-plugin/commit/341c001bedb163a60b1db3967a4a72810f516417 Author: Robert Sandell <rsand...@cloudbees.com> Date: 2015-01-12 (Mon, 12 Jan 2015)
Changed paths: M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/GerritManagement.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/GerritProjectListUpdater.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/GerritServer.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/PluginImpl.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/api/GerritTriggerApi.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/dependency/DependencyQueueTaskDispatcher.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/extensions/GerritTriggeredBuildListener.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/NotificationFactory.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ParameterExpander.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ToGerritRunListener.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/model/BuildMemory.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/BadgeAction.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/EventListener.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritCause.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritConnectionListener.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritItemListener.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerParameters.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerTimer.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerTimerTask.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/UnreviewedPatchesListener.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/actions/manual/ManualTriggerAction.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/data/GerritProject.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/events/PluginCommentAddedEvent.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/events/PluginDraftPublishedEvent.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/replication/ReplicationQueueTaskDispatcher.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/replication/WaitingForReplication.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/version/GerritVersionChecker.java M src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritItemListenerTest.java M src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerParametersTest.java M src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerTest.java M src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/actions/manual/ManualTriggerActionTest.java M src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/version/VersionCheckTest.java Log Message: ----------- Findbugs: null pointer dereference fixes. The bump in core version introduced @CheckforNull on Jenkins.getInstance and escalated to PluginImpl.getInstance. Added some static helper/shortcut methods in PluginImpl so not too many new if statements littering the rest of the code. This commit should fix all current, including old, "possible null pointer dereference" warnings. Commit: d413773f0409a073b7ca46575bb71c460f8cca40 https://github.com/jenkinsci/gerrit-trigger-plugin/commit/d413773f0409a073b7ca46575bb71c460f8cca40 Author: Robert Sandell <rsand...@cloudbees.com> Date: 2015-01-13 (Tue, 13 Jan 2015) Changed paths: M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/PluginImpl.java Log Message: ----------- Lowering log level for plugin and Jenkins instance not found Commit: edf0298f06bca81901800ac196d1fbd59c806ec9 https://github.com/jenkinsci/gerrit-trigger-plugin/commit/edf0298f06bca81901800ac196d1fbd59c806ec9 Author: Robert Sandell <rsand...@cloudbees.com> Date: 2015-01-13 (Tue, 13 Jan 2015) Changed paths: M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ToGerritRunListener.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java Log Message: ----------- Annotated onCompleted to simplify if And one more small null pointer warning that was hiding behind another category. Commit: 03aa3aca784c5b2f3cb4b0ace338a22c81be98c0 https://github.com/jenkinsci/gerrit-trigger-plugin/commit/03aa3aca784c5b2f3cb4b0ace338a22c81be98c0 Author: Robert Sandell <rsand...@cloudbees.com> Date: 2015-01-15 (Thu, 15 Jan 2015) Changed paths: M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/GerritManagement.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/GerritProjectListUpdater.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/GerritServer.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/PluginImpl.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/api/GerritTriggerApi.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/dependency/DependencyQueueTaskDispatcher.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/extensions/GerritTriggeredBuildListener.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/NotificationFactory.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ParameterExpander.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ToGerritRunListener.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/model/BuildMemory.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/BadgeAction.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/EventListener.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritCause.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritConnectionListener.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritItemListener.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerParameters.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerTimer.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerTimerTask.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/UnreviewedPatchesListener.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/actions/manual/ManualTriggerAction.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/data/GerritProject.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/events/PluginCommentAddedEvent.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/events/PluginDraftPublishedEvent.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/replication/ReplicationQueueTaskDispatcher.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/replication/WaitingForReplication.java M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/version/GerritVersionChecker.java M src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritItemListenerTest.java M src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerParametersTest.java M src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerTest.java M src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/actions/manual/ManualTriggerActionTest.java M src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/version/VersionCheckTest.java Log Message: ----------- Merge pull request #197 from jenkinsci/findbugs Findbugs: null pointer dereference fixes. Compare: https://github.com/jenkinsci/gerrit-trigger-plugin/compare/3833e8d1c599...03aa3aca784c -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.