Branch: refs/heads/config-id-JENKINS-26099
Home: https://github.com/jenkinsci/credentials-plugin
Commit: f4dbb2b39e9ed399dfd0b5907bc13d62c019b60f
https://github.com/jenkinsci/credentials-plugin/commit/f4dbb2b39e9ed399dfd0b5907bc13d62c019b60f
Author: Jesse Glick <jgl...@cloudbees.com>
Date: 2015-01-13 (Tue, 13 Jan 2015)
Changed paths:
M
src/main/java/com/cloudbees/plugins/credentials/impl/CertificateCredentialsImpl.java
Log Message:
-----------
toCharArray can return null (never an empty array), yet you cannot pass null
to KeyStore.getKey.
It will throw a NullPointerException, not an UnrecoverableEntryException.
This caused an ugly stack trace to be shown when the password was not available
to form validation.
Could retrieve key "1". You may need to provide a password
java.security.UnrecoverableKeyException: Get Key failed: null
at
sun.security.pkcs12.PKCS12KeyStore.engineGetKey(PKCS12KeyStore.java:295)
at java.security.KeyStore.getKey(KeyStore.java:792)
at
com.cloudbees.plugins.credentials.impl.CertificateCredentialsImpl$KeyStoreSourceDescriptor.validateCertificateKeystore(CertificateCredentialsImpl.java:224)
at
com.cloudbees.plugins.credentials.impl.CertificateCredentialsImpl$FileOnMasterKeyStoreSource$DescriptorImpl.doCheckKeyStoreFile(CertificateCredentialsImpl.java:333)
at …
Caused by: java.lang.NullPointerException
at
sun.security.pkcs12.PKCS12KeyStore.engineGetKey(PKCS12KeyStore.java:269)
... 69 more
Commit: fc7055dd1795084d069d62a8b0fa2e3053f64f39
https://github.com/jenkinsci/credentials-plugin/commit/fc7055dd1795084d069d62a8b0fa2e3053f64f39
Author: Jesse Glick <jgl...@cloudbees.com>
Date: 2015-01-14 (Wed, 14 Jan 2015)
Changed paths:
M
src/main/java/com/cloudbees/plugins/credentials/impl/CertificateCredentialsImpl.java
Log Message:
-----------
Merge pull request #22 from jenkinsci/credentials-upload
Trying to fix certificate upload & password checking
Commit: 454539ff337181c433cd4bbd9df9a5e168ac8d81
https://github.com/jenkinsci/credentials-plugin/commit/454539ff337181c433cd4bbd9df9a5e168ac8d81
Author: Jesse Glick <jgl...@cloudbees.com>
Date: 2015-01-14 (Wed, 14 Jan 2015)
Changed paths:
M
src/main/java/com/cloudbees/plugins/credentials/impl/CertificateCredentialsImpl.java
Log Message:
-----------
Merge branch 'master' into config-id-JENKINS-26099
Compare:
https://github.com/jenkinsci/credentials-plugin/compare/221d8f47be38...454539ff3371
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
