Branch: refs/heads/develop
Home: https://github.com/jenkinsci/google-compute-engine-plugin
Commit: 1bd91c345a49f23eb8d21b2a103184a1ea3aaac9
https://github.com/jenkinsci/google-compute-engine-plugin/commit/1bd91c345a49f23eb8d21b2a103184a1ea3aaac9
Author: James Nord <[email protected]>
Date: 2024-05-02 (Thu, 02 May 2024)
Changed paths:
M pom.xml
Log Message:
-----------
do attempt to shade dependencies.
Was introduced in
https://github.com/jenkinsci/google-compute-engine-plugin/commit/49dc7bcf4b7f8f89e5bac86085eee1d64aa0c54b
but this is a waste of space.
as the shade runs after the hpi package all that happens is that the
classess get copied into the root of the HPI.
classes are never loaded from here and there is a copy in
WEB-INF\lib\gcp-client-xxx.jar that is used, and this has been working
for a while.
whilst there may also be a gcp-client in other places that this plugin
has dependencies to I saw no gcp-client in google-oath-credentials
wheich would be the only logical place. Additionally if it where not
broken before this fix it would remain not broken after this fix.
Commit: 284b25b107cdad6781b56ec9e9d258f75a6ec042
https://github.com/jenkinsci/google-compute-engine-plugin/commit/284b25b107cdad6781b56ec9e9d258f75a6ec042
Author: James Nord <[email protected]>
Date: 2024-05-03 (Fri, 03 May 2024)
Changed paths:
M pom.xml
Log Message:
-----------
Merge pull request #458 from jtnord/remove-bogus-shade
do attempt to shade dependencies.
Compare:
https://github.com/jenkinsci/google-compute-engine-plugin/compare/7ebc656e6658...284b25b107cd
To unsubscribe from these emails, change your notification settings at
https://github.com/jenkinsci/google-compute-engine-plugin/settings/notifications
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/google-compute-engine-plugin/push/refs/heads/develop/7ebc65-284b25%40github.com.
