Branch: refs/heads/master Home: https://github.com/jenkinsci/remoting Commit: 55352b350b9e3e3d98bd8f19bf05f3df9007b7db https://github.com/jenkinsci/remoting/commit/55352b350b9e3e3d98bd8f19bf05f3df9007b7db Author: Kohsuke Kawaguchi <k...@kohsuke.org> Date: 2014-09-06 (Sat, 06 Sep 2014)
Changed paths: A src/test/java/OISInterception.java Log Message: ----------- Experimenting with inspecting stream contents as it is read. Commit: 34ee26305659638f0087f6868858884829470054 https://github.com/jenkinsci/remoting/commit/34ee26305659638f0087f6868858884829470054 Author: Kohsuke Kawaguchi <k...@kohsuke.org> Date: 2014-09-06 (Sat, 06 Sep 2014) Changed paths: A src/main/java/hudson/remoting/CallableDecorator.java A src/main/java/hudson/remoting/CallableDecoratorAdapter.java A src/main/java/hudson/remoting/CallableDecoratorList.java M src/main/java/hudson/remoting/CallableFilter.java M src/main/java/hudson/remoting/Channel.java M src/main/java/hudson/remoting/InterceptingExecutorService.java M src/main/java/hudson/remoting/UserRequest.java M src/test/java/hudson/remoting/ChannelFilterTest.java Log Message: ----------- Evolved CallableFilter into CallableDecorator ... to add another method that decorates UserRequest Commit: 4af7907fdcaf0ae6cbeba369e30b80ec642d0afa https://github.com/jenkinsci/remoting/commit/4af7907fdcaf0ae6cbeba369e30b80ec642d0afa Author: Kohsuke Kawaguchi <k...@kohsuke.org> Date: 2014-09-06 (Sat, 06 Sep 2014) Changed paths: M src/main/java/hudson/remoting/CallableDecorator.java Log Message: ----------- Doc improvement Commit: 1bd53fc7909c6b858b9db7bcc726a726c2c6124b https://github.com/jenkinsci/remoting/commit/1bd53fc7909c6b858b9db7bcc726a726c2c6124b Author: Kohsuke Kawaguchi <k...@kohsuke.org> Date: 2014-09-06 (Sat, 06 Sep 2014) Changed paths: M src/test/java/hudson/remoting/ChannelFilterTest.java Log Message: ----------- Added a test case Commit: f4e47530185dddf57a6b636bce79fde475d9aa45 https://github.com/jenkinsci/remoting/commit/f4e47530185dddf57a6b636bce79fde475d9aa45 Author: Kohsuke Kawaguchi <k...@kohsuke.org> Date: 2014-09-08 (Mon, 08 Sep 2014) Changed paths: M src/main/java/hudson/remoting/CallableDecorator.java Log Message: ----------- Doc improvements Commit: 900ad75183a786a24830fb7595b8128cc4c76241 https://github.com/jenkinsci/remoting/commit/900ad75183a786a24830fb7595b8128cc4c76241 Author: Kohsuke Kawaguchi <k...@kohsuke.org> Date: 2014-09-08 (Mon, 08 Sep 2014) Changed paths: M pom.xml M src/main/java/hudson/remoting/Channel.java M src/main/java/hudson/remoting/ChunkedInputStream.java M src/main/java/hudson/remoting/ChunkedOutputStream.java M src/main/java/hudson/remoting/Engine.java M src/main/java/hudson/remoting/EngineListener.java M src/main/java/hudson/remoting/EngineListenerAdapter.java M src/main/java/hudson/remoting/EngineListenerSplitter.java M src/main/java/hudson/remoting/ExportTable.java M src/main/java/hudson/remoting/FastPipedInputStream.java M src/main/java/hudson/remoting/FlightRecorderInputStream.java M src/main/java/hudson/remoting/Pipe.java M src/main/java/hudson/remoting/ProxyInputStream.java M src/main/java/hudson/remoting/ProxyOutputStream.java M src/main/java/hudson/remoting/ProxyWriter.java A src/main/java/hudson/remoting/ReferenceCountRecorder.java M src/main/java/hudson/remoting/RemoteClassLoader.java M src/main/java/hudson/remoting/RemoteInvocationHandler.java M src/main/java/hudson/remoting/RemoteWriter.java M src/main/java/hudson/remoting/SocketChannelStream.java M src/main/java/hudson/remoting/SystemException.java M src/main/java/hudson/remoting/UnexportCommand.java M src/main/java/hudson/remoting/UserRequest.java M src/main/java/hudson/remoting/Util.java M src/main/java/hudson/remoting/jnlp/GuiListener.java M src/main/java/hudson/remoting/jnlp/Main.java M src/main/java/org/jenkinsci/remoting/nio/Closeables.java M src/main/java/org/jenkinsci/remoting/nio/NioChannelHub.java M src/test/java/hudson/remoting/ChannelTest.java M src/test/java/hudson/remoting/ClassRemotingTest.java M src/test/java/hudson/remoting/DeadRemoteOutputStreamTest.java M src/test/java/hudson/remoting/DummyClassLoader.java M src/test/java/hudson/remoting/DummyClassLoaderTest.java A src/test/java/hudson/remoting/ExportTableTest.java M src/test/java/hudson/remoting/FlightRecorderInputStreamTest.java M src/test/java/hudson/remoting/PrefetchingTest.java M src/test/java/hudson/remoting/ProxyWriterTest.java A src/test/java/hudson/remoting/util/GCTask.java Log Message: ----------- Merge 2.45 into SECURITY-144 Commit: d6d7593fb7fa4f40d5c8f803f2e22b7e5edf6ad7 https://github.com/jenkinsci/remoting/commit/d6d7593fb7fa4f40d5c8f803f2e22b7e5edf6ad7 Author: Kohsuke Kawaguchi <k...@kohsuke.org> Date: 2014-09-18 (Thu, 18 Sep 2014) Changed paths: M src/main/java/hudson/remoting/CallableDecorator.java Log Message: ----------- doc improvement Commit: de498a7ca8f14687ba63c5fa8a7d4f452f9b39aa https://github.com/jenkinsci/remoting/commit/de498a7ca8f14687ba63c5fa8a7d4f452f9b39aa Author: Kohsuke Kawaguchi <k...@kohsuke.org> Date: 2014-09-18 (Thu, 18 Sep 2014) Changed paths: M src/main/java/hudson/remoting/Channel.java M src/main/java/hudson/remoting/ChannelBuilder.java Log Message: ----------- Adding Decorator after a channel is created can be too late ... as the slave could have already sent us Callables. To really ensure every Callable gets decorated, we need to have them in ChannelBuilder Commit: c1bd53e9a9845031594770da35c194539c1733d4 https://github.com/jenkinsci/remoting/commit/c1bd53e9a9845031594770da35c194539c1733d4 Author: Jesse Glick <jgl...@cloudbees.com> Date: 2014-09-19 (Fri, 19 Sep 2014) Changed paths: M src/main/java/hudson/remoting/CallableDecorator.java Log Message: ----------- Added @since. Commit: bff921ff7f8ab5cd7eac2e93fed3230f17af9aa2 https://github.com/jenkinsci/remoting/commit/bff921ff7f8ab5cd7eac2e93fed3230f17af9aa2 Author: Jesse Glick <jgl...@cloudbees.com> Date: 2014-09-22 (Mon, 22 Sep 2014) Changed paths: M src/main/java/hudson/remoting/CallableDecoratorList.java Log Message: ----------- Typo. Commit: b6365ceabfeed2fd3a6fab4bdf0586bbadf4608e https://github.com/jenkinsci/remoting/commit/b6365ceabfeed2fd3a6fab4bdf0586bbadf4608e Author: Jesse Glick <jgl...@cloudbees.com> Date: 2014-09-23 (Tue, 23 Sep 2014) Changed paths: M src/main/java/hudson/remoting/CallableDecorator.java Log Message: ----------- Fixed Javadoc to make it clear that you delegate to stem, not op. Commit: 5b57ae0732079b152d68b28c1cd9eb5ec57844d6 https://github.com/jenkinsci/remoting/commit/5b57ae0732079b152d68b28c1cd9eb5ec57844d6 Author: Kohsuke Kawaguchi <k...@kohsuke.org> Date: 2014-09-23 (Tue, 23 Sep 2014) Changed paths: M src/main/java/hudson/remoting/Callable.java M src/main/java/hudson/remoting/ChannelBuilder.java A src/main/java/org/jenkinsci/remoting/Role.java A src/main/java/org/jenkinsci/remoting/RoleChecker.java A src/main/java/org/jenkinsci/remoting/RoleSensitive.java Log Message: ----------- Introducing the mechanism to verify that the Callables we are getting is legitimate. This change introduces Role, which designates the part one side plays in the overall protocol (such as "client" or "server".) Callable and other Callable-like classes (like FileCallable seen in Jenkins) should implement this RoleSensitive interface to declare the intended place the Callables run. This information is then used as a basis for decision making to allow/refuse Callables. RoleChecker does this, and it gets installed as a CallableDecorator. This change also makes a bold move to have Callable implement the newly added RoleSensitive, breaking source compatibility. Fortunately, this change doesn't affect binary compatibility, and the care is taken to warn the caller that it might see AbstractMethodError. This change forces each Callable implementation to think about where it can be run, which provides static check and helps those users of this library that wants to enforce this role mechanism (such as Jenkins.) It is indeed a nuisance for users who have symmetric protocol (for example, the most of unit tests in this library), but the trade-off is judged positive as the most critical user of this library (Jenkins) has an asymmetric protocol. Commit: f3de59ae767566a053b1db44973f9c87f96be408 https://github.com/jenkinsci/remoting/commit/f3de59ae767566a053b1db44973f9c87f96be408 Author: Kohsuke Kawaguchi <k...@kohsuke.org> Date: 2014-09-23 (Tue, 23 Sep 2014) Changed paths: M src/main/java/hudson/remoting/Channel.java M src/main/java/hudson/remoting/PingThread.java M src/main/java/hudson/remoting/PreloadJarTask.java M src/main/java/hudson/remoting/RemoteInvocationHandler.java M src/main/java/hudson/remoting/forward/ForwarderFactory.java M src/main/java/hudson/remoting/forward/PortForwarder.java M src/main/java/org/jenkinsci/remoting/nio/NioChannelHub.java A src/test/java/hudson/remoting/CallableBase.java M src/test/java/hudson/remoting/ChannelFilterTest.java M src/test/java/hudson/remoting/ChannelTest.java M src/test/java/hudson/remoting/ClassRemotingTest.java M src/test/java/hudson/remoting/DeadRemoteOutputStreamTest.java M src/test/java/hudson/remoting/NonSerializableExceptionTest.java M src/test/java/hudson/remoting/PipeTest.java M src/test/java/hudson/remoting/PipeWriterTest.java M src/test/java/hudson/remoting/PrefetchTest.java M src/test/java/hudson/remoting/PrefetchingTest.java M src/test/java/hudson/remoting/ProxyWriterTest.java M src/test/java/hudson/remoting/RemoteInputStreamTest.java M src/test/java/hudson/remoting/RemoteInvocationHandlerTest.java M src/test/java/hudson/remoting/SimpleTest.java M src/test/java/hudson/remoting/TestCallable.java M src/test/java/hudson/remoting/TestLinkage.java M src/test/java/hudson/remoting/throughput/Sender.java M src/test/java/hudson/remoting/util/GCTask.java M src/test/java/org/jenkinsci/remoting/nio/SocketClientMain.java Log Message: ----------- Made all Callables implement the getRecipients() method. See the previous commit for the context and the discussion of this change. This commit is more or less just the implementation details Commit: f84f83d6c420c068b1974cb912da420aefb6c2b5 https://github.com/jenkinsci/remoting/commit/f84f83d6c420c068b1974cb912da420aefb6c2b5 Author: Kohsuke Kawaguchi <k...@kohsuke.org> Date: 2014-09-23 (Tue, 23 Sep 2014) Changed paths: M src/main/java/hudson/remoting/Channel.java M src/main/java/hudson/remoting/ChannelBuilder.java M src/main/java/hudson/remoting/RemoteClassLoader.java M src/main/java/hudson/remoting/UserRequest.java Log Message: ----------- Allow controlling classloading and Callable restriction separately Commit: ce547bfab64158541c01d382687a9bdd201e6ee9 https://github.com/jenkinsci/remoting/commit/ce547bfab64158541c01d382687a9bdd201e6ee9 Author: Jesse Glick <jgl...@cloudbees.com> Date: 2014-09-24 (Wed, 24 Sep 2014) Changed paths: R src/main/java/hudson/remoting/CallableDecorator.java M src/main/java/hudson/remoting/CallableDecoratorAdapter.java M src/main/java/hudson/remoting/CallableDecoratorList.java M src/main/java/hudson/remoting/Channel.java M src/main/java/hudson/remoting/ChannelBuilder.java A src/main/java/org/jenkinsci/remoting/CallableDecorator.java M src/test/java/hudson/remoting/ChannelFilterTest.java Log Message: ----------- CallableDecorator is newly added, so belongs in the package for new classes. Commit: 3bfbe5c9aeb28e1ed11f6ee50fa8b088fa4e9ade https://github.com/jenkinsci/remoting/commit/3bfbe5c9aeb28e1ed11f6ee50fa8b088fa4e9ade Author: Jesse Glick <jgl...@cloudbees.com> Date: 2014-09-24 (Wed, 24 Sep 2014) Changed paths: M src/main/java/org/jenkinsci/remoting/Role.java Log Message: ----------- Unused constructor. Commit: 36f7ded6ba2aab6570df0ba6cc0bb7ee58d15a98 https://github.com/jenkinsci/remoting/commit/36f7ded6ba2aab6570df0ba6cc0bb7ee58d15a98 Author: Jesse Glick <jgl...@cloudbees.com> Date: 2014-09-24 (Wed, 24 Sep 2014) Changed paths: M src/main/java/org/jenkinsci/remoting/Role.java Log Message: ----------- @stephenc suggests equals/hashCode for Role. (Not following suggestion to do writeReplace.) I am also making it final. Basically it is like an extensible enum. Commit: af1bf1e6bbf8377f401ae7afa533c75e30aa7333 https://github.com/jenkinsci/remoting/commit/af1bf1e6bbf8377f401ae7afa533c75e30aa7333 Author: Jesse Glick <jgl...@cloudbees.com> Date: 2014-09-24 (Wed, 24 Sep 2014) Changed paths: M src/main/java/hudson/remoting/Channel.java M src/main/java/hudson/remoting/ChannelBuilder.java M src/main/java/hudson/remoting/RemoteClassLoader.java M src/main/java/hudson/remoting/UserRequest.java Log Message: ----------- More consistent naming convention. Commit: c93e398bde3d3d59cb0ac72459e8ee53702e0f2c https://github.com/jenkinsci/remoting/commit/c93e398bde3d3d59cb0ac72459e8ee53702e0f2c Author: Jesse Glick <jgl...@cloudbees.com> Date: 2014-09-24 (Wed, 24 Sep 2014) Changed paths: M src/main/java/org/jenkinsci/remoting/Role.java Log Message: ----------- Revert "Unused constructor." This reverts commit 3bfbe5c9aeb28e1ed11f6ee50fa8b088fa4e9ade. Apparently it was used after all. Commit: e385561d0d3eaea3b730fdbccff34874facee5ac https://github.com/jenkinsci/remoting/commit/e385561d0d3eaea3b730fdbccff34874facee5ac Author: Jesse Glick <jgl...@cloudbees.com> Date: 2014-09-24 (Wed, 24 Sep 2014) Changed paths: M src/main/java/org/jenkinsci/remoting/Role.java M src/main/java/org/jenkinsci/remoting/RoleChecker.java M src/main/java/org/jenkinsci/remoting/RoleSensitive.java Log Message: ----------- Make sure new APIs are marked with @since. Commit: 944fb8a801f8d39efbbe21b46401859a7f2d76c3 https://github.com/jenkinsci/remoting/commit/944fb8a801f8d39efbbe21b46401859a7f2d76c3 Author: Kohsuke Kawaguchi <k...@kohsuke.org> Date: 2014-09-24 (Wed, 24 Sep 2014) Changed paths: M src/main/java/hudson/remoting/Channel.java M src/main/java/hudson/remoting/ChannelBuilder.java M src/main/java/hudson/remoting/PingThread.java M src/main/java/hudson/remoting/PreloadJarTask.java M src/main/java/hudson/remoting/RemoteInvocationHandler.java M src/main/java/hudson/remoting/forward/ForwarderFactory.java M src/main/java/hudson/remoting/forward/PortForwarder.java M src/main/java/org/jenkinsci/remoting/RoleChecker.java M src/main/java/org/jenkinsci/remoting/RoleSensitive.java M src/main/java/org/jenkinsci/remoting/nio/NioChannelHub.java M src/test/java/hudson/remoting/CallableBase.java M src/test/java/hudson/remoting/TestCallable.java Log Message: ----------- Revisiting RoleChecker To work with composition of Callables better, make Callable call back to RoleChecker. This works better for more complex role requirements, such as "(X or Y) and (A or B)" Commit: 93f20281ee7769e65e33687be33d1b1e3201091e https://github.com/jenkinsci/remoting/commit/93f20281ee7769e65e33687be33d1b1e3201091e Author: Kohsuke Kawaguchi <k...@kohsuke.org> Date: 2014-09-24 (Wed, 24 Sep 2014) Changed paths: M src/main/java/hudson/remoting/Channel.java M src/main/java/hudson/remoting/Request.java M src/main/java/hudson/remoting/SystemException.java M src/main/java/hudson/remoting/UserRequest.java Log Message: ----------- Reimplemented the way we capture call site stack information. This approach preserves the fidelity of the exception thrown, compared to the re-wrapping by another exception type. Commit: fe7bcfaf6914fbce94fe9be54e568c29f3ade52d https://github.com/jenkinsci/remoting/commit/fe7bcfaf6914fbce94fe9be54e568c29f3ade52d Author: Jesse Glick <jgl...@cloudbees.com> Date: 2014-09-24 (Wed, 24 Sep 2014) Changed paths: M src/main/java/hudson/remoting/RequestAbortedException.java Log Message: ----------- Compilation fix. Commit: d2ba1c121e0b3c712e8556268611c8fddec0e72b https://github.com/jenkinsci/remoting/commit/d2ba1c121e0b3c712e8556268611c8fddec0e72b Author: Kohsuke Kawaguchi <k...@kohsuke.org> Date: 2014-09-24 (Wed, 24 Sep 2014) Changed paths: M src/main/java/hudson/remoting/Channel.java Log Message: ----------- I'm finding some use case in Jenkins that involves subtyping Channel. It's probably not something we encourage, but other constructors do allow that, so I'm exposing this Commit: 5f0f0882e8d9db20d7dbecb2bcaf5a57ba908f34 https://github.com/jenkinsci/remoting/commit/5f0f0882e8d9db20d7dbecb2bcaf5a57ba908f34 Author: Kohsuke Kawaguchi <k...@kohsuke.org> Date: 2014-09-24 (Wed, 24 Sep 2014) Changed paths: M src/main/java/hudson/remoting/Channel.java M src/main/java/hudson/remoting/ChannelBuilder.java Log Message: ----------- Adding a method to add a new property during channel building Commit: 8b576ecdf33f6c1207c4a62b3a44b7fda574b3e0 https://github.com/jenkinsci/remoting/commit/8b576ecdf33f6c1207c4a62b3a44b7fda574b3e0 Author: Jesse Glick <jgl...@cloudbees.com> Date: 2014-09-24 (Wed, 24 Sep 2014) Changed paths: M src/main/java/hudson/remoting/Channel.java M src/main/java/hudson/remoting/ChannelBuilder.java Log Message: ----------- @since Commit: 8e3254de1a49720bf33324ef15fbd1c63adc479f https://github.com/jenkinsci/remoting/commit/8e3254de1a49720bf33324ef15fbd1c63adc479f Author: Kohsuke Kawaguchi <k...@kohsuke.org> Date: 2014-09-24 (Wed, 24 Sep 2014) Changed paths: M src/main/java/hudson/remoting/Channel.java M src/main/java/hudson/remoting/ExportTable.java M src/main/java/hudson/remoting/Pipe.java M src/main/java/hudson/remoting/RemoteClassLoader.java M src/main/java/hudson/remoting/RemoteInputStream.java M src/main/java/hudson/remoting/RemoteInvocationHandler.java M src/main/java/hudson/remoting/RemoteOutputStream.java M src/main/java/hudson/remoting/RemoteWriter.java M src/test/java/hudson/remoting/ExportTableTest.java M src/test/java/hudson/remoting/RemoteInvocationHandlerTest.java Log Message: ----------- Merge SECURITY-150 fix into SECURITY-144 We decided to ship SECURITY-150 first, so there's no need to use SECURITY-144 without SECURITY-150. When I test SECURITY-144, I want to get SECURITY-150 too. Commit: 0893b7ea489a0d520473f824ae161b53032aefd6 https://github.com/jenkinsci/remoting/commit/0893b7ea489a0d520473f824ae161b53032aefd6 Author: Kohsuke Kawaguchi <k...@kohsuke.org> Date: 2014-09-24 (Wed, 24 Sep 2014) Changed paths: M src/test/java/hudson/remoting/RemoteInvocationHandlerTest.java Log Message: ----------- Fixup for the previous merge Commit: 04159fd175edb4ee74d5aac34ab85d2b4e071bbe https://github.com/jenkinsci/remoting/commit/04159fd175edb4ee74d5aac34ab85d2b4e071bbe Author: Kohsuke Kawaguchi <k...@kohsuke.org> Date: 2014-09-24 (Wed, 24 Sep 2014) Changed paths: M src/main/java/org/jenkinsci/remoting/nio/NioChannelHub.java Log Message: ----------- Merge remote-tracking branch 'community/master' into SECURITY-144 Commit: c8f6a8857b06238595b31b5bd24993f393a8bad4 https://github.com/jenkinsci/remoting/commit/c8f6a8857b06238595b31b5bd24993f393a8bad4 Author: Jesse Glick <jgl...@cloudbees.com> Date: 2014-10-09 (Thu, 09 Oct 2014) Changed paths: M pom.xml Log Message: ----------- Merge branch 'master' into SECURITY-144 Commit: 2f67a72abac8e383c0cf801a7841588083ba02ea https://github.com/jenkinsci/remoting/commit/2f67a72abac8e383c0cf801a7841588083ba02ea Author: Kohsuke Kawaguchi <k...@kohsuke.org> Date: 2014-10-09 (Thu, 09 Oct 2014) Changed paths: M src/main/java/hudson/remoting/Channel.java Log Message: ----------- The meaning of the flag is negated, so "!" is crucial Commit: 2b8c2b72a4a53c198f89c8fe3a18d86f55bda9f5 https://github.com/jenkinsci/remoting/commit/2b8c2b72a4a53c198f89c8fe3a18d86f55bda9f5 Author: Kohsuke Kawaguchi <k...@kohsuke.org> Date: 2014-10-13 (Mon, 13 Oct 2014) Changed paths: M pom.xml A src/findbugs-filter.xml M src/main/java/hudson/remoting/ExportTable.java M src/main/java/hudson/remoting/GCCommand.java M src/main/java/hudson/remoting/JarLoaderImpl.java M src/main/java/hudson/remoting/Launcher.java M src/main/java/hudson/remoting/PreloadJarTask.java M src/main/java/hudson/remoting/RemoteClassLoader.java M src/main/java/hudson/remoting/RemoteInvocationHandler.java M src/main/java/hudson/remoting/Request.java M src/main/java/hudson/remoting/forward/ForwarderFactory.java Log Message: ----------- Merge remote-tracking branch 'community/master' into SECURITY-144 Conflicts: src/main/java/hudson/remoting/PreloadJarTask.java Commit: 5e5a17089562a6470795de8635e4dee64692f451 https://github.com/jenkinsci/remoting/commit/5e5a17089562a6470795de8635e4dee64692f451 Author: Kohsuke Kawaguchi <k...@kohsuke.org> Date: 2014-10-13 (Mon, 13 Oct 2014) Changed paths: M src/main/java/hudson/remoting/CallableDecoratorList.java Log Message: ----------- More fix to make FindBugs happy Commit: 8405880509093f58e5876ee4ffff2b86e6a41e5d https://github.com/jenkinsci/remoting/commit/8405880509093f58e5876ee4ffff2b86e6a41e5d Author: Kohsuke Kawaguchi <k...@kohsuke.org> Date: 2014-10-29 (Wed, 29 Oct 2014) Changed paths: M pom.xml Log Message: ----------- [maven-release-plugin] prepare release remoting-2.47 Compare: https://github.com/jenkinsci/remoting/compare/8227da4c234c...840588050909 -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.