[jenkinsci/generic-webhook-trigger-plugin] f591ee: feat: change filter to optional parameter in Job D...

['임준영' via Jenkins Commits]

  Branch: refs/heads/master
  Home:   https://github.com/jenkinsci/generic-webhook-trigger-plugin
  Commit: f591ee21a57f716530a533f886f6db54637307d1
      
https://github.com/jenkinsci/generic-webhook-trigger-plugin/commit/f591ee21a57f716530a533f886f6db54637307d1
  Author: 임준영 <j...@lguplus.co.kr>
  Date:   2023-10-14 (Sat, 14 Oct 2023)

  Changed paths:
    M src/main/java/org/jenkinsci/plugins/gwt/GenericTrigger.java
    M src/test/java/org/jenkinsci/plugins/gwt/jobfinder/JobFinderTest.java

  Log Message:
  -----------
  feat: change filter to optional parameter in Job DSL (#280)

Detail
======
 - Fix #83
 - The `Expression (regexpFilterExpression)` and `Text
   (regexpFilterText)` is optional field in Web UI, but there are
   required parameter in Job DSL (because constructor use those params.)
 - Excluding these two fields from constructor, and adding setter.
 - Tested with 1.87.0 and this new version.
   - using 1.87.0, in `Job DSL API Reference`
     - the field is required
     - 
![image](https://github.com/jenkinsci/generic-webhook-trigger-plugin/assets/16630665/b6dbaccb-c637-4a8a-9441-c83f465ccef3)
   - using this commit, in `Job DSL API Reference`
     - the field is not required
     - 
![image](https://github.com/jenkinsci/generic-webhook-trigger-plugin/assets/16630665/6fc19dba-a30c-4021-b165-025909b186e6)
   - using 1.87.0, without `regexpFilterText`, `regexpFilterExpression`
     - 
![image](https://github.com/jenkinsci/generic-webhook-trigger-plugin/assets/16630665/de92ed0c-4d77-40b5-80c8-afc34304bdc1)
     - 
![image](https://github.com/jenkinsci/generic-webhook-trigger-plugin/assets/16630665/8db1a3d1-93d2-47ca-b663-0c530cdb1c06)
   - with this commit, without `regexpFilterText`, `regexpFilterExpression`
     - 
![image](https://github.com/jenkinsci/generic-webhook-trigger-plugin/assets/16630665/5b0eab26-2e0f-4168-9bc2-2be3f69431c3)
   - with this commit, with `regexpFilterText`, `regexpFilterExpression`
     - 
![image](https://github.com/jenkinsci/generic-webhook-trigger-plugin/assets/16630665/b94d3ab7-0ebf-45eb-be68-c11a6b5876e2)


-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/generic-webhook-trigger-plugin/push/refs/heads/master/832267-f591ee%40github.com.