Branch: refs/heads/master
Home: https://github.com/jenkinsci/docker-plugin
Commit: 1c4d7c7a622ee142edc30cd5f58ee424f8a3d9ca
https://github.com/jenkinsci/docker-plugin/commit/1c4d7c7a622ee142edc30cd5f58ee424f8a3d9ca
Author: Mark Waite <[email protected]>
Date: 2023-09-04 (Mon, 04 Sep 2023)
Changed paths:
M
src/test/java/com/nirima/jenkins/plugins/docker/utils/JenkinsUtilsTest.java
Log Message:
-----------
[JENKINS-70729] Stop supporting an empty cloud name
https://github.com/jenkinsci/jenkins/pull/7658 reworks cloud management
to use multiple pages instead of a single large page. That rework also
requires that a cloud may not be named with an empty string.
The docker plugin specifically tested that a cloud was allowed to have an
empty string as its name, but performed no other operations with a cloud
that is named with an empty string. Cloud named with an empty string may
have worked prior to Jenkins 2.403, but they would have been complicated
to manage, especially in a controller with multiple clouds defined.
A cloud named with an empty string is much more difficult to manage.
It is better to mention in the changelog that clouds are no longer
allowed to have an empty name rather than wrestling with all the ways
that an empty name will break cloud administration.
https://issues.jenkins.io/browse/JENKINS-70729 is the enhancement request
that implements the change.
https://issues.jenkins.io/browse/JENKINS-71825 is the bug report for
the automated test failure that started this investigation.
Commit: 4a89186544da9c64e68c73c34b0c8bfe8909ccb4
https://github.com/jenkinsci/docker-plugin/commit/4a89186544da9c64e68c73c34b0c8bfe8909ccb4
Author: Mark Waite <[email protected]>
Date: 2023-09-04 (Mon, 04 Sep 2023)
Changed paths:
M src/main/java/com/nirima/jenkins/plugins/docker/DockerCloud.java
M src/test/java/com/nirima/jenkins/plugins/docker/DockerCloudTest.java
Log Message:
-----------
Log a warning if a DockerCloud name is blank
Do not break existing usage of blank names, but warn in the log file
that blank names are no longer supported after Jenkins 2.402.
The Jenkins 2.421 cloud creation UI will not allow a blank name, but
earlier versions may have allowed it.
Assert the log message for blank or name cloud name
Commit: d2092acfeec4dd0bbee7c46bf2319805b038cef2
https://github.com/jenkinsci/docker-plugin/commit/d2092acfeec4dd0bbee7c46bf2319805b038cef2
Author: Mark Waite <[email protected]>
Date: 2023-09-04 (Mon, 04 Sep 2023)
Changed paths:
M src/main/java/com/nirima/jenkins/plugins/docker/DockerCloud.java
Log Message:
-----------
Log blank or null cloud name in readResolve
Commit: 4579c0c723c41f92838a65c93e647de60d991969
https://github.com/jenkinsci/docker-plugin/commit/4579c0c723c41f92838a65c93e647de60d991969
Author: Mark Waite <[email protected]>
Date: 2023-09-04 (Mon, 04 Sep 2023)
Changed paths:
M src/main/java/com/nirima/jenkins/plugins/docker/DockerCloud.java
M src/test/java/com/nirima/jenkins/plugins/docker/DockerCloudTest.java
Log Message:
-----------
Convert empty or blank name to non-blank in readResolve
Jenkins 2.403 improves the cloud management user interface. Each cloud is
now managed from a separate page. That separate page requires a non-blank
name for the cloud. Jenkins 2.402 and later allowed a blank name.
When a blank name is detected, convert it to a non-blank name based on
the hashCode of the DockerAPI and templates.
Compare:
https://github.com/jenkinsci/docker-plugin/compare/e36429178d88...4579c0c723c4
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/docker-plugin/push/refs/heads/master/e36429-4579c0%40github.com.
