Branch: refs/heads/master Home: https://github.com/jenkinsci/github-pr-comment-build-plugin Commit: 00d64c442964433f4ac4a3096bfab821b468ea9c https://github.com/jenkinsci/github-pr-comment-build-plugin/commit/00d64c442964433f4ac4a3096bfab821b468ea9c Author: Pascal Hofmann <m...@pascalhofmann.de> Date: 2023-03-16 (Thu, 16 Mar 2023)
Changed paths: M src/main/java/com/adobe/jenkins/github_pr_comment_build/GithubHelper.java M src/main/java/com/adobe/jenkins/github_pr_comment_build/IssueCommentGHEventSubscriber.java M src/main/java/com/adobe/jenkins/github_pr_comment_build/PRReviewGHEventSubscriber.java M src/main/java/com/adobe/jenkins/github_pr_comment_build/PRUpdateGHEventSubscriber.java A src/main/java/com/adobe/jenkins/github_pr_comment_build/TriggerBranchProperty.java A src/main/java/com/adobe/jenkins/github_pr_comment_build/TriggerBranchPropertyDescriptorImpl.java M src/main/java/com/adobe/jenkins/github_pr_comment_build/TriggerPRCommentBranchProperty.java M src/main/java/com/adobe/jenkins/github_pr_comment_build/TriggerPRReviewBranchProperty.java M src/main/java/com/adobe/jenkins/github_pr_comment_build/TriggerPRUpdateBranchProperty.java M src/main/resources/com/adobe/jenkins/github_pr_comment_build/TriggerPRCommentBranchProperty/config.jelly M src/main/resources/com/adobe/jenkins/github_pr_comment_build/TriggerPRCommentBranchProperty/help-commentBody.html M src/main/resources/com/adobe/jenkins/github_pr_comment_build/TriggerPRReviewBranchProperty/config.jelly M src/main/resources/com/adobe/jenkins/github_pr_comment_build/TriggerPRUpdateBranchProperty/config.jelly Log Message: ----------- Add configurable minimum permissions for triggers For private repositories people with `Read` role (aka `pull` permission) are seen as collaborators by the GitHub API. This means, they were able trigger builds with older versions of the plugin. This change fixes this, and also adds the option to limit triggering of builds to repository admins. The existing `allowUntrusted` toggle is dropped from the UI. This change adds a new drop-down `Minimum Permissions on repository to trigger the build` with these options: - Only users with admin permission - Only users that can push to the repository (default) - Allow untrusted users to trigger the build Commit: e96c665954e26f848b3da459d7a37eccb1d0d37f https://github.com/jenkinsci/github-pr-comment-build-plugin/commit/e96c665954e26f848b3da459d7a37eccb1d0d37f Author: Brian Saville <bksavi...@gmail.com> Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M src/main/java/com/adobe/jenkins/github_pr_comment_build/GithubHelper.java M src/main/java/com/adobe/jenkins/github_pr_comment_build/IssueCommentGHEventSubscriber.java M src/main/java/com/adobe/jenkins/github_pr_comment_build/PRReviewGHEventSubscriber.java M src/main/java/com/adobe/jenkins/github_pr_comment_build/PRUpdateGHEventSubscriber.java A src/main/java/com/adobe/jenkins/github_pr_comment_build/TriggerBranchProperty.java A src/main/java/com/adobe/jenkins/github_pr_comment_build/TriggerBranchPropertyDescriptorImpl.java M src/main/java/com/adobe/jenkins/github_pr_comment_build/TriggerPRCommentBranchProperty.java M src/main/java/com/adobe/jenkins/github_pr_comment_build/TriggerPRReviewBranchProperty.java M src/main/java/com/adobe/jenkins/github_pr_comment_build/TriggerPRUpdateBranchProperty.java M src/main/resources/com/adobe/jenkins/github_pr_comment_build/TriggerPRCommentBranchProperty/config.jelly M src/main/resources/com/adobe/jenkins/github_pr_comment_build/TriggerPRCommentBranchProperty/help-commentBody.html M src/main/resources/com/adobe/jenkins/github_pr_comment_build/TriggerPRReviewBranchProperty/config.jelly M src/main/resources/com/adobe/jenkins/github_pr_comment_build/TriggerPRUpdateBranchProperty/config.jelly Log Message: ----------- Merge pull request #60 from pascal-hofmann/configurable-minimum-permissions Add configurable minimum permissions for triggers Compare: https://github.com/jenkinsci/github-pr-comment-build-plugin/compare/4f61f9313700...e96c665954e2 -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/github-pr-comment-build-plugin/push/refs/heads/master/4f61f9-e96c66%40github.com.