Branch: refs/heads/master

  Home:   https://github.com/jenkinsci/mq-notifier-plugin

  Commit: db830c56d227b1827210d2f8e318a5b5b8f5ee67

      
https://github.com/jenkinsci/mq-notifier-plugin/commit/db830c56d227b1827210d2f8e318a5b5b8f5ee67

  Author: Magnus Bäck <magnus.b...@axis.com>

  Date:   2022-12-09 (Fri, 09 Dec 2022)



  Changed paths:

    M 
src/main/java/com/sonymobile/jenkins/plugins/mq/mqnotifier/MQConnection.java



  Log Message:

  -----------

  Don't start message queue thread until after initialization



For some time there's been a race condition during Jenkins startup

between the sending of the first event and the initialization of

the message queue thread.



The AMQP configuration is passed to MQConnection via initialize(),

called from MQNotifierConfig#configure(). Until this has happened,

the MQConnection's AMQP URL will be null and any attempt to send an

event will trigger an NPE.



We solve this by introducing an MQConnection#initialized attribute

that's set to true only after we've received the configuration, and

until then the message queue thread won't be started. We still post

messages to the queue, though, so any early messages will eventually

be sent.





  Commit: 0ddf232b8af7b874e6eca4cb24775e618c7a93c5

      
https://github.com/jenkinsci/mq-notifier-plugin/commit/0ddf232b8af7b874e6eca4cb24775e618c7a93c5

  Author: Tomas Westling <tom...@axis.com>

  Date:   2023-01-24 (Tue, 24 Jan 2023)



  Changed paths:

    M 
src/main/java/com/sonymobile/jenkins/plugins/mq/mqnotifier/MQConnection.java



  Log Message:

  -----------

  Merge pull request #45 from magnusbaeck/startup-race



Fix startup race condition that put the outbound message queue in a bad state





Compare: 
https://github.com/jenkinsci/mq-notifier-plugin/compare/451e8843e90f...0ddf232b8af7

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/mq-notifier-plugin/push/refs/heads/master/451e88-0ddf23%40github.com.

Reply via email to