Branch: refs/heads/master
Home: https://github.com/jenkinsci/jenkins
Commit: f0cbe387d5521ecc33b81fef13b09bbbc67edc0e
https://github.com/jenkinsci/jenkins/commit/f0cbe387d5521ecc33b81fef13b09bbbc67edc0e
Author: Mark Waite <mark.earl.wa...@gmail.com>
Date: 2023-01-07 (Sat, 07 Jan 2023)
Changed paths:
M core/src/main/resources/jenkins/split-plugin-cycles.txt
M core/src/main/resources/jenkins/split-plugins.txt
M war/pom.xml
Log Message:
-----------
[JENKINS-70301] Do not report implied dependencies for WMI Windows Agents
plugin (#7568)
* Hide split of windows-slaves from other plugins
https://issues.jenkins.io/browse/JENKINS-70301 notes that the WMI Windows
Agents plugin (id:windows-slaves) was split from core in 1.547 and is
now deprecated. Because it is deprecated, users want to remove it.
They cannot remove it if they have plugins installed that depend on a
Jenkins version prior to 1.547.
Only two plugins actually depend of any classes from the WMI Windows
Agent plugin.
* cli-extras-plugin - never released, no tags, no install history
* multi-slave-config - already requires windows-slaves plugin explicitly
and already requires a Jenkins core version newer than 1.547. 1340
installations, last released 8 years ago
Rather than require updates of all the plugins that require a Jenkins
version less than 1.547, this removes the windows-slaves plugin from the
split plugins list. Users will not be warned that their plugin might
have a dependency on windows-slaves because the analysis has confirmed
that there is only 1 delivered plugin with that dependency, and it is
an explicitly declared dependency with a newer Jenkins minimum version
than the version from which the WMI Windows Agents plugion was split.
Testing done
* Installed suggested plugins from wizard and confirmed WMI Windows
Agents plugin is not installed
* Installed slave-setup plugin (has implied WMI Windows Agents plugin
dependency) and confirmed that WMI Windows Agents plugin is not installed
* Installed multi-slave-setup plugin (has explicit WMI Windows Agents
plugin dependency) and confirmed that WMI Windows Agents plugin was
installed as a dependency
* Remove multi-slave-setup plugin and WMI Windows Agents plugin and
confirmed that Jenkins reported no errors or issues
* Installed five plugins with old base versions and confirmed
that WMI Windows Agents plugin was not installed. The five plugins
included backup-plugin, cloudbees-credentials-plugin, unity3d-plugin,
groovy-label-assignment-plugin, and maven-deployment-linker plugin.
* Performed a backup with the backup plugin and confirmed that it was
well behaved
https://docs.google.com/spreadsheets/d/1KDIJIu41rIRlj6PjzyhAY9vazKmd3PVwqM3_-32Lt-o/edit?usp=sharing
lists the plugins that have an implied dependency on the WMI Windows
Agents plugin.
* Remove windows-slaves from war file
No need to bundle a detached plugin that has no consumers of its API
that are based on a Jenkins version before the plugin was split from core.
https://github.com/jenkinsci/jenkins/pull/7568#pullrequestreview-1238137930
detected that the bundling was left in by the original commit.
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/jenkins/push/refs/heads/master/284441-f0cbe3%40github.com.
