Branch: refs/heads/master
Home: https://github.com/jenkinsci/gerrit-trigger-plugin
Commit: 5fd098bbf8ccda45838265c35fadf6bb98333d92
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/5fd098bbf8ccda45838265c35fadf6bb98333d92
Author: Chris Allen <[email protected]>
Date: 2022-07-18 (Mon, 18 Jul 2022)
Changed paths:
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/config/GerritJcascConfigurator.java
A
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/JcascServerConnectTest.java
Log Message:
-----------
JENKINS-69050: Stop old server instances correctly during JCasC update
When applying a configuration update to the Gerrit Trigger plugin
via "Jenkins Configuration as Code", a reference to the list of
server instances was saved instead of creating a new list. This
meant that after the configuration was updated, the list reference
pointed at the new list of server instances and not the old one,
and hence failed to shutdown the old server connections.
This patch additionally avoids restarting the existing server
connections unnecessarily when "configure()" is called with
"dryrun" set to true.
Commit: 6d6f963f8ee4fe2957a381e669482d1bb384e128
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/6d6f963f8ee4fe2957a381e669482d1bb384e128
Author: Robert Sandell <[email protected]>
Date: 2022-08-17 (Wed, 17 Aug 2022)
Changed paths:
M
src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/config/GerritJcascConfigurator.java
A
src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/JcascServerConnectTest.java
Log Message:
-----------
Merge pull request #469 from chrisa-arm/JENKINS-69050-jcasc-server-leak-fix
[JENKINS-69050] Stop old server instances correctly during JCasC update
Compare:
https://github.com/jenkinsci/gerrit-trigger-plugin/compare/2fb80fd20ba1...6d6f963f8ee4
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/gerrit-trigger-plugin/push/refs/heads/master/2fb80f-6d6f96%40github.com.
