Branch: refs/heads/master
  Home:   https://github.com/jenkinsci/acceptance-test-harness
  Commit: 76a306e74379bc90aa4720711701dc96884a641e
      
https://github.com/jenkinsci/acceptance-test-harness/commit/76a306e74379bc90aa4720711701dc96884a641e
  Author: James Nord <[email protected]>
  Date:   2022-08-16 (Tue, 16 Aug 2022)

  Changed paths:
    M 
src/main/java/org/jenkinsci/test/acceptance/selenium/UselessFileDetectorReplacement.java

  Log Message:
  -----------
  the WebDriver may be wrapped so we also need to unwrap it

The WebDriver may be wrapped or unwrapped so we need to unwarp it to get
the underlying driver to see if that is a RemoteWebDriver to configure
the FileDetector


  Commit: b390530d6363d6a8c89aeef193b4e4a7edd44fe2
      
https://github.com/jenkinsci/acceptance-test-harness/commit/b390530d6363d6a8c89aeef193b4e4a7edd44fe2
  Author: James Nord <[email protected]>
  Date:   2022-08-16 (Tue, 16 Aug 2022)

  Changed paths:
    M 
src/main/java/org/jenkinsci/test/acceptance/selenium/UselessFileDetectorReplacement.java

  Log Message:
  -----------
  not all remoteWEbdrivers are created equally

fixes

Setting the file detector only works on remote webdriver instances obtained via 
RemoteWebDriver
Build info: version: '3.141.59', revision: 'e82be7d358', time: 
'2018-11-14T08:17:03'
System info: host: '5ef48d7c6e03', ip: '172.17.0.2', os.name: 'Linux', os.arch: 
'amd64', os.version: '5.15.0-1014-azure', java.version: '11.0.16'
Driver info: driver.version: FirefoxDriver


  Commit: 989cb85644ae28c70dd641ec573442906d4bbfbe
      
https://github.com/jenkinsci/acceptance-test-harness/commit/989cb85644ae28c70dd641ec573442906d4bbfbe
  Author: James Nord <[email protected]>
  Date:   2022-08-16 (Tue, 16 Aug 2022)

  Changed paths:
    M 
src/main/java/org/jenkinsci/test/acceptance/plugins/credentials/Credential.java
    M src/main/java/org/jenkinsci/test/acceptance/po/SlavesMixIn.java

  Log Message:
  -----------
  deflake SshSlavesPluginTest#connectWithKey

2 flakes in one

1. the scroller bypass was not hooked up so locally for me the test (on
   2.360 would fail as the credential select was blocked by the
     breadcrumb bar)
2. on ci.jenkins.io the test would fail as the dropdown would be
   obscured by the remenants of the credentials dialog (the button would
   be removed before the dialog was removed) so we wait for the dailog
   to be hidden instead


Compare: 
https://github.com/jenkinsci/acceptance-test-harness/compare/37cfb200e475...989cb85644ae

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/acceptance-test-harness/push/refs/heads/master/37cfb2-989cb8%40github.com.

Reply via email to