Branch: refs/heads/master Home: https://github.com/jenkinsci/jenkins Commit: 48e92efaed7d48d6bd515a7844f9c055a8e27f6b https://github.com/jenkinsci/jenkins/commit/48e92efaed7d48d6bd515a7844f9c055a8e27f6b Author: Jesse Glick <jgl...@cloudbees.com> Date: 2014-04-02 (Wed, 02 Apr 2014)
Changed paths: M core/src/main/java/hudson/model/AbstractProject.java M core/src/main/java/hudson/tasks/BuildTrigger.java M test/src/test/java/hudson/tasks/BuildTriggerTest.java Log Message: ----------- [JENKINS-16956] Make BuildTrigger.execute pay attention to build permissions, rather than checking the configuring user. Commit: d31ff2fed352cc15d808cb8aa91eba6576ed13ae https://github.com/jenkinsci/jenkins/commit/d31ff2fed352cc15d808cb8aa91eba6576ed13ae Author: Jesse Glick <jgl...@cloudbees.com> Date: 2014-04-02 (Wed, 02 Apr 2014) Changed paths: M core/src/main/java/hudson/tasks/BuildTrigger.java M core/src/main/resources/hudson/tasks/Messages.properties M test/src/test/java/hudson/tasks/BuildTriggerTest.java Log Message: ----------- [JENKINS-16956] More compatible behavior: if no QIA’s are configured yet, fall back to running as SYSTEM. Also make a best effort to issue a warning in the log if downstream builds might skipped due to lack of authentication; or if downstream build permissions might not be checked due to legacy behavior. Commit: a8d879eacdc358594b764ce82f710837ebf6e454 https://github.com/jenkinsci/jenkins/commit/a8d879eacdc358594b764ce82f710837ebf6e454 Author: Jesse Glick <jgl...@cloudbees.com> Date: 2014-04-02 (Wed, 02 Apr 2014) Changed paths: M core/src/main/java/hudson/tasks/BuildStep.java Log Message: ----------- Documenting expectations of build steps needing specific authentication. Commit: ef382f90a5f80dc60e24eeabd30293c48740f8d2 https://github.com/jenkinsci/jenkins/commit/ef382f90a5f80dc60e24eeabd30293c48740f8d2 Author: Jesse Glick <jgl...@cloudbees.com> Date: 2014-04-03 (Thu, 03 Apr 2014) Changed paths: M core/src/main/java/hudson/model/AbstractProject.java M core/src/main/java/hudson/model/DependencyGraph.java M core/src/main/java/hudson/model/queue/Tasks.java M core/src/main/java/hudson/tasks/BuildTrigger.java M core/src/main/java/jenkins/security/QueueItemAuthenticator.java M test/src/test/java/hudson/tasks/BuildTriggerTest.java Log Message: ----------- Introduced a QueueItemAuthenticator overload taking Task. And moving the permissions checks in BuildTrigger from being hardcoded in execute to being overridable in Dependency. This has two benefits: · We can restore the previous form validation logic predicting whether Item.BUILD will be available. · A (true) Trigger could check Item.READ on the upstream project under the authentication that the downstream project would have if it were to be built. (This part is not yet implemented; probably will want to make this replace the current pseudotriggers.) Commit: 3342d74182aee25a502478334ac63d06d82f6f6d https://github.com/jenkinsci/jenkins/commit/3342d74182aee25a502478334ac63d06d82f6f6d Author: Jesse Glick <jgl...@cloudbees.com> Date: 2014-04-09 (Wed, 09 Apr 2014) Changed paths: M changelog.html M cli/pom.xml M core/pom.xml M core/src/main/java/hudson/FilePath.java M core/src/main/java/hudson/Launcher.java M core/src/main/java/hudson/cli/ClientAuthenticationCache.java M core/src/main/java/hudson/model/ItemGroupMixIn.java M core/src/main/java/hudson/model/Items.java M core/src/main/java/hudson/model/Result.java M core/src/main/java/hudson/model/Slave.java M core/src/main/java/hudson/os/SU.java M core/src/main/java/hudson/slaves/SlaveComputer.java M core/src/main/java/hudson/tools/AbstractCommandInstaller.java M core/src/main/java/hudson/util/ProcessTree.java M core/src/main/java/jenkins/model/Jenkins.java M core/src/main/java/jenkins/slaves/JnlpSlaveAgentProtocol.java M core/src/main/java/jenkins/slaves/JnlpSlaveAgentProtocol2.java M core/src/main/resources/hudson/model/User/configure.jelly M core/src/main/resources/hudson/model/User/configure.properties M core/src/main/resources/hudson/model/User/configure_bg.properties M core/src/main/resources/hudson/model/User/configure_ca.properties M core/src/main/resources/hudson/model/User/configure_cs.properties M core/src/main/resources/hudson/model/User/configure_da.properties M core/src/main/resources/hudson/model/User/configure_de.properties M core/src/main/resources/hudson/model/User/configure_es.properties M core/src/main/resources/hudson/model/User/configure_fr.properties M core/src/main/resources/hudson/model/User/configure_hu.properties M core/src/main/resources/hudson/model/User/configure_id.properties M core/src/main/resources/hudson/model/User/configure_it.properties M core/src/main/resources/hudson/model/User/configure_ja.properties M core/src/main/resources/hudson/model/User/configure_ko.properties M core/src/main/resources/hudson/model/User/configure_lv.properties M core/src/main/resources/hudson/model/User/configure_nb_NO.properties M core/src/main/resources/hudson/model/User/configure_nl.properties M core/src/main/resources/hudson/model/User/configure_pl.properties M core/src/main/resources/hudson/model/User/configure_pt_BR.properties M core/src/main/resources/hudson/model/User/configure_ru.properties M core/src/main/resources/hudson/model/User/configure_sk.properties M core/src/main/resources/hudson/model/User/configure_sv_SE.properties M core/src/main/resources/hudson/model/User/configure_tr.properties M core/src/main/resources/hudson/model/User/configure_uk.properties M core/src/main/resources/hudson/model/User/configure_zh_CN.properties M core/src/main/resources/hudson/model/User/configure_zh_TW.properties M core/src/main/resources/lib/hudson/aggregated-failed-tests.jelly M core/src/main/resources/lib/hudson/failed-test.jelly M core/src/test/java/hudson/FilePathTest.java M core/src/test/java/hudson/LauncherTest.java M debian/debian/changelog M plugins/pom.xml M pom.xml M test/pom.xml M test/src/test/java/hudson/diagnosis/OldDataMonitorTest.java M war/pom.xml Log Message: ----------- Merge branch 'master' into BuildTrigger-auth-JENKINS-16956 Commit: 7f033ec9fa69cbdbd043311dbb52b8299052b2f1 https://github.com/jenkinsci/jenkins/commit/7f033ec9fa69cbdbd043311dbb52b8299052b2f1 Author: Jesse Glick <jgl...@cloudbees.com> Date: 2014-04-09 (Wed, 09 Apr 2014) Changed paths: M core/src/main/java/hudson/Functions.java M core/src/main/resources/lib/hudson/project/config-upstream-pseudo-trigger.jelly Log Message: ----------- p:config-upstream-pseudo-trigger is actually applicable to AbstractProject, not only Project. Commit: 840bb66944783f07dc551062f8274a6608a11214 https://github.com/jenkinsci/jenkins/commit/840bb66944783f07dc551062f8274a6608a11214 Author: Jesse Glick <jgl...@cloudbees.com> Date: 2014-04-10 (Thu, 10 Apr 2014) Changed paths: M core/src/main/java/hudson/model/AbstractProject.java M core/src/main/java/hudson/tasks/BuildTrigger.java A core/src/main/java/jenkins/triggers/ReverseBuildTrigger.java M core/src/main/resources/hudson/matrix/MatrixProject/configure-entries.jelly M core/src/main/resources/hudson/model/Project/configure-entries.jelly A core/src/main/resources/jenkins/triggers/Messages.properties A core/src/main/resources/jenkins/triggers/ReverseBuildTrigger/config.jelly A core/src/main/resources/jenkins/triggers/ReverseBuildTrigger/help.html A core/src/main/resources/jenkins/triggers/ReverseBuildTrigger/help_de.html A core/src/main/resources/jenkins/triggers/ReverseBuildTrigger/help_fr.html A core/src/main/resources/jenkins/triggers/ReverseBuildTrigger/help_ja.html A core/src/main/resources/jenkins/triggers/ReverseBuildTrigger/help_pt_BR.html A core/src/main/resources/jenkins/triggers/ReverseBuildTrigger/help_ru.html A core/src/main/resources/jenkins/triggers/ReverseBuildTrigger/help_tr.html A core/src/main/resources/jenkins/triggers/ReverseBuildTrigger/help_zh_TW.html M core/src/main/resources/lib/hudson/project/config-upstream-pseudo-trigger.jelly M test/src/test/java/hudson/model/FreeStyleProjectTest.java M test/src/test/java/hudson/model/ProjectTest.java M test/src/test/java/hudson/tasks/BuildTriggerTest.java R war/src/main/webapp/help/project-config/upstream.html R war/src/main/webapp/help/project-config/upstream_de.html R war/src/main/webapp/help/project-config/upstream_fr.html R war/src/main/webapp/help/project-config/upstream_ja.html R war/src/main/webapp/help/project-config/upstream_pt_BR.html R war/src/main/webapp/help/project-config/upstream_ru.html R war/src/main/webapp/help/project-config/upstream_tr.html R war/src/main/webapp/help/project-config/upstream_zh_TW.html Log Message: ----------- Replacing pseudoUpstreamTrigger with ReverseBuildTrigger. Commit: e321cbb4bc9b3b239a411c2ecb5cfe431905d0fe https://github.com/jenkinsci/jenkins/commit/e321cbb4bc9b3b239a411c2ecb5cfe431905d0fe Author: Jesse Glick <jgl...@cloudbees.com> Date: 2014-04-11 (Fri, 11 Apr 2014) Changed paths: M changelog.html M cli/src/main/java/hudson/cli/CLI.java M cli/src/main/java/hudson/cli/Connection.java M core/src/main/java/hudson/Launcher.java M core/src/main/java/hudson/TcpSlaveAgentListener.java M core/src/main/java/hudson/cli/CliProtocol.java M core/src/main/java/hudson/cli/CliProtocol2.java M core/src/main/java/hudson/model/AbstractBuild.java M core/src/main/java/hudson/model/ItemGroupMixIn.java M core/src/main/java/hudson/model/ReconfigurableDescribable.java M core/src/main/java/hudson/model/Run.java M core/src/main/java/hudson/model/ViewDescriptor.java M core/src/main/java/hudson/model/listeners/RunListener.java M core/src/main/java/hudson/slaves/Channels.java M core/src/main/java/jenkins/model/ParameterizedJobMixIn.java M core/src/main/java/jenkins/model/lazy/LazyBuildMixIn.java M core/src/main/java/jenkins/slaves/JnlpSlaveAgentProtocol.java M core/src/main/java/jenkins/slaves/JnlpSlaveAgentProtocol2.java A core/src/main/java/jenkins/slaves/NioChannelSelector.java M pom.xml M war/src/main/webapp/WEB-INF/web.xml M war/src/main/webapp/scripts/hudson-behavior.js Log Message: ----------- Merge branch 'master' into BuildTrigger-auth-JENKINS-16956 Commit: b53139e0db15d1a9b8f6b8eac5b08c33ea40566b https://github.com/jenkinsci/jenkins/commit/b53139e0db15d1a9b8f6b8eac5b08c33ea40566b Author: Jesse Glick <jgl...@cloudbees.com> Date: 2014-04-11 (Fri, 11 Apr 2014) Changed paths: M test/src/test/groovy/hudson/model/AbstractProjectTest.groovy Log Message: ----------- Test of JENKINS-13502 fix is obsolete since we no longer check permissions when configuring triggers. Commit: 32a8e9dd2a04e61d7ba6ceea66f2ca6021722e5b https://github.com/jenkinsci/jenkins/commit/32a8e9dd2a04e61d7ba6ceea66f2ca6021722e5b Author: Jesse Glick <jgl...@cloudbees.com> Date: 2014-04-11 (Fri, 11 Apr 2014) Changed paths: M core/src/main/java/jenkins/triggers/ReverseBuildTrigger.java Log Message: ----------- Some mistakes turned up by FindBugs and BuildTriggerTest stack traces. Commit: d4b5549d605f828c5736a04b9233484bfd6bd3fa https://github.com/jenkinsci/jenkins/commit/d4b5549d605f828c5736a04b9233484bfd6bd3fa Author: Jesse Glick <jgl...@cloudbees.com> Date: 2014-04-11 (Fri, 11 Apr 2014) Changed paths: M test/src/test/java/hudson/tasks/BuildTriggerTest.java Log Message: ----------- No sense in spending ~20s running HtmlUnit to verify code which has since been deleted anyway (configuration-time ACL checks). Commit: ac220e3f2b39f68b6c374523e5dc563dbf57ef74 https://github.com/jenkinsci/jenkins/commit/ac220e3f2b39f68b6c374523e5dc563dbf57ef74 Author: Jesse Glick <jgl...@cloudbees.com> Date: 2014-04-11 (Fri, 11 Apr 2014) Changed paths: M test/src/test/java/hudson/model/NodeTest.java M test/src/test/java/hudson/model/QueueTest.java Log Message: ----------- Unnecessary and misleading for a QueueItemAuthenticator to be a @TestExtension. (It may have a @TestExtension QueueItemAuthenticatorDescriptor if one is needed.) Commit: 772e36662ec860d1f613e619f8ae3e62650ea1d4 https://github.com/jenkinsci/jenkins/commit/772e36662ec860d1f613e619f8ae3e62650ea1d4 Author: Jesse Glick <jgl...@cloudbees.com> Date: 2014-04-11 (Fri, 11 Apr 2014) Changed paths: A test/src/main/java/org/jvnet/hudson/test/MockQueueItemAuthenticator.java M test/src/test/java/hudson/model/NodeTest.java M test/src/test/java/hudson/model/QueueTest.java M test/src/test/java/hudson/tasks/BuildTriggerTest.java Log Message: ----------- Introduced MockQueueItemAuthenticator as a convenience. Commit: 26ec7bdf936dfbc3f496b1165cea36488a3a06b2 https://github.com/jenkinsci/jenkins/commit/26ec7bdf936dfbc3f496b1165cea36488a3a06b2 Author: Jesse Glick <jgl...@cloudbees.com> Date: 2014-04-11 (Fri, 11 Apr 2014) Changed paths: M core/src/main/java/hudson/tasks/BuildTrigger.java M core/src/main/java/jenkins/triggers/ReverseBuildTrigger.java M core/src/main/resources/jenkins/triggers/Messages.properties M test/src/test/java/hudson/tasks/BuildTriggerTest.java A test/src/test/java/jenkins/triggers/ReverseBuildTriggerTest.java Log Message: ----------- Properly testing ReverseBuildTrigger, and refining what information is displayed in build logs. Commit: 7f76a93dd947cb0180a36d2ce54b1e3c2ddaf3bc https://github.com/jenkinsci/jenkins/commit/7f76a93dd947cb0180a36d2ce54b1e3c2ddaf3bc Author: Jesse Glick <jgl...@cloudbees.com> Date: 2014-04-11 (Fri, 11 Apr 2014) Changed paths: M changelog.html M core/src/main/java/hudson/model/queue/Tasks.java M core/src/main/java/jenkins/security/QueueItemAuthenticator.java M core/src/main/java/jenkins/triggers/ReverseBuildTrigger.java Log Message: ----------- [FIXED JENKINS-16956] Noting merge of #1172. Compare: https://github.com/jenkinsci/jenkins/compare/a1cd49b948ab...7f76a93dd947 -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.