Branch: refs/heads/master
Home: https://github.com/jenkinsci/p4-plugin
Commit: fbf6c8a0933288fe7cce79e658320a83088dfed6
https://github.com/jenkinsci/p4-plugin/commit/fbf6c8a0933288fe7cce79e658320a83088dfed6
Author: Tim Lander <tim57...@hotmail.com>
Date: 2022-05-16 (Mon, 16 May 2022)
Changed paths:
M src/main/java/org/jenkinsci/plugins/p4/review/ReviewAction.java
Log Message:
-----------
[WIP] Change `status` to be a choice instead of a string
`status` is described as:
>(Required field) The review status; must be one of the following strings:
>shelved, committed or submitted.
To me this sounds like a better match for a `ChoiceParameterDefinition`, as
that can both enforce this parameter being required and limit the choices to
the available choices.
Commit: ea699e695e686abb65d81739ef35ea7ffdb719fe
https://github.com/jenkinsci/p4-plugin/commit/ea699e695e686abb65d81739ef35ea7ffdb719fe
Author: Tim Lander <tim57...@hotmail.com>
Date: 2022-05-16 (Mon, 16 May 2022)
Changed paths:
M src/main/java/org/jenkinsci/plugins/p4/review/ReviewAction.java
Log Message:
-----------
Correct anonymous array syntax
Commit: 81190d03c520fe52130d0c78c0e0eb0b2e15ac0f
https://github.com/jenkinsci/p4-plugin/commit/81190d03c520fe52130d0c78c0e0eb0b2e15ac0f
Author: Paul Allen <pal...@perforce.com>
Date: 2022-05-17 (Tue, 17 May 2022)
Changed paths:
M src/main/java/org/jenkinsci/plugins/p4/review/ReviewAction.java
Log Message:
-----------
Merge pull request #144 from VirtualTim/patch-1
Change `status` to be a choice instead of a string
Compare:
https://github.com/jenkinsci/p4-plugin/compare/865ff0f60528...81190d03c520
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/p4-plugin/push/refs/heads/master/865ff0-81190d%40github.com.
