Branch: refs/heads/spotbugs-fixes
Home: https://github.com/jenkinsci/gearman-plugin
Commit: 0f984f14fd3049f2a45102bf186df6824b8f3286
https://github.com/jenkinsci/gearman-plugin/commit/0f984f14fd3049f2a45102bf186df6824b8f3286
Author: Antoine Musso <has...@free.fr>
Date: 2022-01-17 (Mon, 17 Jan 2022)
Changed paths:
M src/main/java/hudson/plugins/gearman/AbstractWorkerThread.java
Log Message:
-----------
AbstractWorkerThread: add missing synchronization
When running the worker, a call to initWorker() is done to create the
GearmanNIOJobServerConnectionImpl which is synchronized. The server
connection is then added to the worker but that was not synchronized
causing spotbugs to complain:
Inconsistent synchronization of
hudson.plugins.gearman.AbstractWorkerThread.conn;
locked 50% of time
Commit: 595f444e049fac1bfef884bcbc1d44870e85f64d
https://github.com/jenkinsci/gearman-plugin/commit/595f444e049fac1bfef884bcbc1d44870e85f64d
Author: Antoine Musso <has...@free.fr>
Date: 2022-01-17 (Mon, 17 Jan 2022)
Changed paths:
M src/main/java/hudson/plugins/gearman/GearmanProxy.java
Log Message:
-----------
GearmanProxy: please spotbugs NPE for getComputer("")
The Jenkins getComputer() method can return `null` when the requested
name does not match any Computer. There is always an unamed Computer
which is the built-in node and the method would never return `null` in
that case.
Addresses spotbugs NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE
Commit: f6676392e346a2434917117805c5a93e3d1b5f02
https://github.com/jenkinsci/gearman-plugin/commit/f6676392e346a2434917117805c5a93e3d1b5f02
Author: Antoine Musso <has...@free.fr>
Date: 2022-01-17 (Mon, 17 Jan 2022)
Changed paths:
M run-fast
M src/main/java/hudson/plugins/gearman/GearmanProxy.java
Log Message:
-----------
GearmanProxy: avoid NPE if a finished build has no executor
When the build is finalized we retriever the executor/computer that ran
it to get other works to check the availability lock. Spotbugs
complains `Run.getExecutor()` might be null which really should never
happen. If that is ever the case, throw an IllegalStateException, it
will be caught and reported by Jenkins runListener.
Compare:
https://github.com/jenkinsci/gearman-plugin/compare/0f984f14fd30%5E...f6676392e346
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/gearman-plugin/push/refs/heads/spotbugs-fixes/000000-f66763%40github.com.
