Branch: refs/heads/master
  Home:   https://github.com/jenkinsci/job-dsl-plugin
  Commit: 6b7a8d813c3c3b9f5daf0fcee823c9fd128d8f42
      
https://github.com/jenkinsci/job-dsl-plugin/commit/6b7a8d813c3c3b9f5daf0fcee823c9fd128d8f42
  Author: Jamie Tanna <ja...@jamietanna.co.uk>
  Date:   2021-10-27 (Wed, 27 Oct 2021)

  Changed paths:
    M gradle/wrapper/gradle-wrapper.properties
    M job-dsl-api-viewer/build.gradle
    M job-dsl-plugin/build.gradle
    M settings.gradle

  Log Message:
  -----------
  Upgrade to latest JPI + Gradle versions

Releases were broken with the previous version of the JPI plugin [0],
therefore we needed to try upgrading to the latest version.

As the latest version requires Gradle 6, we have a few changes to make:

- `jenkinsVersion` needs to be referenced through `project.properties`
- the `war` plugin needs to be explicitly added
- the CSS/JS plugins we're using are not yet released[1][2], so we can
  follow the tricks in Spotless[3] to use the version from the (pinned)
  latest commit on GitHub

Next, as we're upgrading the JPI plugin, we need to:

- migrate to using `implementation` / `testImplementation`
- add Feature Variants for each of the `optionalJenkinsPlugins` -
  although I'm not sure if they're needed right now, we'll produce them
  for now and review later

See also https://groups.google.com/g/jenkinsci-dev/c/CDVvgj9dDMs

[0]: https://github.com/jenkinsci/gradle-jpi-plugin/issues/192
[1]: https://github.com/eriwen/gradle-css-plugin/issues/58
[2]: https://github.com/eriwen/gradle-js-plugin/issues/177
[3]: 
https://github.com/diffplug/spotless/blob/a7f25eb51c6d4006591ea911157e62d0213e320b/CONTRIBUTING.md


-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/job-dsl-plugin/push/refs/heads/master/119f93-6b7a8d%40github.com.

Reply via email to