Branch: refs/heads/master
  Home:   https://github.com/jenkinsci/jenkins
  Commit: d7fb1f7ed2ae904e0435dcf23a82e026ae3f12e7
      
https://github.com/jenkinsci/jenkins/commit/d7fb1f7ed2ae904e0435dcf23a82e026ae3f12e7
  Author: Jesse Glick <jgl...@cloudbees.com>
  Date:   2013-10-22 (Tue, 22 Oct 2013)

  Changed paths:
    M core/src/main/java/hudson/model/ComputerSet.java

  Log Message:
  -----------
  Simpler and better to throw Failure than to hand-craft an error result.


  Commit: e6632cdaab2ceccc11e50149056ee682ea2158dc
      
https://github.com/jenkinsci/jenkins/commit/e6632cdaab2ceccc11e50149056ee682ea2158dc
  Author: Jesse Glick <jgl...@cloudbees.com>
  Date:   2013-10-22 (Tue, 22 Oct 2013)

  Changed paths:
    M core/src/main/java/hudson/model/View.java

  Log Message:
  -----------
  Throw Failure, which FormException would just delegate to when we are not 
coming from a regular form’s Apply button, as in this case.


  Commit: bdaea02d88631282389a528eb9a049e6481a4660
      
https://github.com/jenkinsci/jenkins/commit/bdaea02d88631282389a528eb9a049e6481a4660
  Author: Jesse Glick <jgl...@cloudbees.com>
  Date:   2013-10-22 (Tue, 22 Oct 2013)

  Changed paths:
    M core/src/main/java/hudson/DescriptorExtensionList.java
    M core/src/main/java/hudson/model/ComputerSet.java
    M core/src/main/java/hudson/model/ItemGroupMixIn.java
    M core/src/main/java/hudson/model/View.java

  Log Message:
  -----------
  Fail with a clear message when a mode parameter is given but no such 
descriptor exists.
Otherwise get e.g.:
java.lang.IllegalArgumentException: java.lang.NullPointerException
        at hudson.model.ItemGroupMixIn.createProject(ItemGroupMixIn.java:253)
        at 
hudson.model.ItemGroupMixIn.createTopLevelItem(ItemGroupMixIn.java:175)
        at jenkins.model.Jenkins.doCreateItem(Jenkins.java:2827)
        at jenkins.model.Jenkins.doCreateItem(Jenkins.java:308)
        at …
Caused by: java.lang.NullPointerException
        at hudson.model.ItemGroupMixIn.createProject(ItemGroupMixIn.java:251)
        ... 65 more


Compare: 
https://github.com/jenkinsci/jenkins/compare/08aaf2b9b399...bdaea02d8863

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-commits+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to