Branch: refs/heads/master Home: https://github.com/jenkinsci/acceptance-test-harness Commit: 34c66860020d2b5fa0390b32f8659e8aa5cd66aa https://github.com/jenkinsci/acceptance-test-harness/commit/34c66860020d2b5fa0390b32f8659e8aa5cd66aa Author: James Nord <jtn...@users.noreply.github.com> Date: 2021-02-19 (Fri, 19 Feb 2021)
Changed paths: M src/main/java/org/jenkinsci/test/acceptance/FallbackConfig.java Log Message: ----------- Fix windows support when cygwin is on the path. if Cygwin was on the path `which` would work and return a cygwin path - and those are not executable on windows.. e.g. fix the following: ``` [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.293 s <<< FAILURE! - in core.FormValidationTest [ERROR] validate(core.FormValidationTest) Time elapsed: 2.254 s <<< ERROR! com.google.inject.ProvisionException: Unable to provision, see the following errors: 1) Error in custom provider, java.lang.IllegalStateException: The driver executable does not exist: C:\cygdrive\c\tools\geckodriver at org.jenkinsci.test.acceptance.FallbackConfig.createWebDriver(FallbackConfig.java:293) (via modules: org.jenkinsci.test.acceptance.guice.World -> com.google.inject.util.Modules$OverrideModule -> com.google.inject.util.Modules$OverrideModule -> org.jenkinsci.test.acceptance.FallbackConfig) at org.jenkinsci.test.acceptance.FallbackConfig.createWebDriver(FallbackConfig.java:293) (via modules: org.jenkinsci.test.acceptance.guice.World -> com.google.inject.util.Modules$OverrideModule -> com.google.inject.util.Modules$OverrideModule -> org.jenkinsci.test.acceptance.FallbackConfig) while locating org.openqa.selenium.WebDriver ``` Commit: e01af6f6c6c1475d99cc94fa76b8b428ddc09d4e https://github.com/jenkinsci/acceptance-test-harness/commit/e01af6f6c6c1475d99cc94fa76b8b428ddc09d4e Author: James Nord <jtn...@users.noreply.github.com> Date: 2021-02-19 (Fri, 19 Feb 2021) Changed paths: M src/main/java/org/jenkinsci/test/acceptance/FallbackConfig.java Log Message: ----------- remove obsolete comment Commit: cd78f2d6bd97f4fb99685c71e065c57088105597 https://github.com/jenkinsci/acceptance-test-harness/commit/cd78f2d6bd97f4fb99685c71e065c57088105597 Author: James Nord <jtn...@users.noreply.github.com> Date: 2021-03-04 (Thu, 04 Mar 2021) Changed paths: M src/main/java/org/jenkinsci/test/acceptance/FallbackConfig.java Log Message: ----------- Merge pull request #645 from jtnord/fix-driver-location-on-windows Fix driver location support when run on windows and cygwin is in the path. Compare: https://github.com/jenkinsci/acceptance-test-harness/compare/e48e1fddd02b...cd78f2d6bd97 -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/acceptance-test-harness/push/refs/heads/master/e48e1f-cd78f2%40github.com.