Branch: refs/heads/master
Home: https://github.com/jenkinsci/git-plugin
Commit: 6288a8320b47f2d7dee1fa574d1c91d7b7fd48b8
https://github.com/jenkinsci/git-plugin/commit/6288a8320b47f2d7dee1fa574d1c91d7b7fd48b8
Author: Mark Waite <[email protected]>
Date: 2021-02-13 (Sat, 13 Feb 2021)
Changed paths:
M README.adoc
M pom.xml
M src/main/java/hudson/plugins/git/GitSCM.java
M src/main/java/hudson/plugins/git/SubmoduleCombinator.java
M src/main/java/hudson/plugins/git/SubmoduleConfig.java
M src/main/java/hudson/plugins/git/extensions/impl/SubmoduleOption.java
M src/main/java/jenkins/plugins/git/GitSCMBuilder.java
M src/main/java/jenkins/plugins/git/GitStep.java
M
src/main/resources/hudson/plugins/git/GitSCM/help-doGenerateSubmoduleConfigurations.html
M src/main/resources/hudson/plugins/git/GitSCM/help-submoduleCfg.html
M src/main/resources/hudson/plugins/git/SubmoduleConfig/help-branches.html
M
src/main/resources/hudson/plugins/git/SubmoduleConfig/help-submoduleName.html
M
src/main/resources/hudson/plugins/git/extensions/impl/SubmoduleOption/config.groovy
M src/test/java/hudson/plugins/git/AbstractGitProject.java
M src/test/java/hudson/plugins/git/AbstractGitTestCase.java
M src/test/java/hudson/plugins/git/GitPublisherTest.java
M src/test/java/hudson/plugins/git/GitSCMTest.java
M src/test/java/hudson/plugins/git/GitSCMUnitTest.java
M src/test/java/hudson/plugins/git/GitStatusTest.java
M src/test/java/hudson/plugins/git/GitTagActionTest.java
M src/test/java/hudson/plugins/git/SubmoduleCombinatorTest.java
M src/test/java/hudson/plugins/git/SubmoduleConfigTest.java
M
src/test/java/hudson/plugins/git/browser/TFS2013GitRepositoryBrowserTest.java
M
src/test/java/hudson/plugins/git/browser/TFS2013GitRepositoryBrowserXSSTest.java
M src/test/java/hudson/plugins/git/extensions/GitSCMExtensionTest.java
M src/test/java/jenkins/plugins/git/GitJCasCCompatibilityTest.java
M src/test/java/jenkins/plugins/git/GitSCMFileSystemTest.java
M src/test/java/jenkins/plugins/git/GitSCMTelescopeTest.java
M
src/test/java/org/jenkinsci/plugins/gittagmessage/GitTagMessageExtensionTest.java
Log Message:
-----------
[JENKINS-62052] Improve pipeline snippets by removing dead code
Remove doGenerateSubmoduleConfigurations from pipeline syntax.
An experiment was added many years ago to allow git submodule combinations
to be computed by the git plugin. The experiment was briefly available
from the user interface and was then disabled. It has been unavailable
for Freestyle and other classic job types because no user interface was
available to access it.
The experiment was made visible to Pipeline users through the Pipeline
Syntax snippet generator. The snippet generator detected the globally
visible symbols and their use in a data bound constructor and presented
them to the user as required arguments with default values.
Use a data bound setter to ignore the doGenerateSubmoduleConfigurations
value instead of passing it as an argument of the data bound constructor.
Retain the constructor signature for compatbility but simplify the
data bound constructor.
There has been no user interface to support submodule combination
generation and no testing to support submodule combination generation
for many, many releases.
Remove submoduleCfg from pipeline syntax.
The submoduleCfg argument alters doGenerateSubmoduleConfigurations.
Since doGenerateSubmoduleConfigurations has been removed, the submoduleCfg
argument can also be removed from the default pipeline syntax.
It might have been possible for a Pipeline definition to enable
doGenerateSubmoduleConfigurations, but it has not been documented or
described in anything other than the source code.
Existing pipelines will continue to work as expected. User provided
values for doGenerateSubmoduleConfigurations and submoduleCfg will
be ignored.
Commit: 2af2989bfaf02e7e675e852431c3cc0b9c1dda00
https://github.com/jenkinsci/git-plugin/commit/2af2989bfaf02e7e675e852431c3cc0b9c1dda00
Author: Mark Waite <[email protected]>
Date: 2021-02-15 (Mon, 15 Feb 2021)
Changed paths:
M README.adoc
M pom.xml
M src/main/java/hudson/plugins/git/GitSCM.java
M src/main/java/hudson/plugins/git/SubmoduleCombinator.java
M src/main/java/hudson/plugins/git/SubmoduleConfig.java
M src/main/java/hudson/plugins/git/extensions/impl/SubmoduleOption.java
M src/main/java/jenkins/plugins/git/GitSCMBuilder.java
M src/main/java/jenkins/plugins/git/GitStep.java
M
src/main/resources/hudson/plugins/git/GitSCM/help-doGenerateSubmoduleConfigurations.html
M src/main/resources/hudson/plugins/git/GitSCM/help-submoduleCfg.html
M src/main/resources/hudson/plugins/git/SubmoduleConfig/help-branches.html
M
src/main/resources/hudson/plugins/git/SubmoduleConfig/help-submoduleName.html
M
src/main/resources/hudson/plugins/git/extensions/impl/SubmoduleOption/config.groovy
M src/test/java/hudson/plugins/git/AbstractGitProject.java
M src/test/java/hudson/plugins/git/AbstractGitTestCase.java
M src/test/java/hudson/plugins/git/GitPublisherTest.java
M src/test/java/hudson/plugins/git/GitSCMTest.java
M src/test/java/hudson/plugins/git/GitSCMUnitTest.java
M src/test/java/hudson/plugins/git/GitStatusTest.java
M src/test/java/hudson/plugins/git/GitTagActionTest.java
M src/test/java/hudson/plugins/git/SubmoduleCombinatorTest.java
M src/test/java/hudson/plugins/git/SubmoduleConfigTest.java
M
src/test/java/hudson/plugins/git/browser/TFS2013GitRepositoryBrowserTest.java
M
src/test/java/hudson/plugins/git/browser/TFS2013GitRepositoryBrowserXSSTest.java
M src/test/java/hudson/plugins/git/extensions/GitSCMExtensionTest.java
M src/test/java/jenkins/plugins/git/GitJCasCCompatibilityTest.java
M src/test/java/jenkins/plugins/git/GitSCMFileSystemTest.java
M src/test/java/jenkins/plugins/git/GitSCMTelescopeTest.java
M
src/test/java/org/jenkinsci/plugins/gittagmessage/GitTagMessageExtensionTest.java
Log Message:
-----------
Merge pull request #1043 from MarkEWaite/deprecate-submodule-combinator
[JENKINS-62052] Remove submodule configurator to improve pipeline snippets
Compare:
https://github.com/jenkinsci/git-plugin/compare/db7ae21d7987...2af2989bfaf0
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/git-plugin/push/refs/heads/master/db7ae2-2af298%40github.com.
