Branch: refs/heads/master
  Home:   https://github.com/jenkinsci/jenkins
  Commit: 31d1ff2ad19239557d2a8a47b97e256d56e1e893
      
https://github.com/jenkinsci/jenkins/commit/31d1ff2ad19239557d2a8a47b97e256d56e1e893
  Author: Ronny Perinke <sephir...@sephiroth-j.de>
  Date:   2020-11-24 (Tue, 24 Nov 2020)

  Changed paths:
    M war/src/main/webapp/scripts/hudson-behavior.js

  Log Message:
  -----------
  Remove unneeded and falsy String.trim polyfill (#5066)

1. [it is not required anymore since 
ages](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/Trim#Browser_compatibility)
2. If "this" is of type type "object", an instance of the same type is 
returned. [This is completely wrong, because it should be 
"string"](https://tc39.es/ecma262/#sec-string.prototype.trim), which causes 
things like [sorting in BootstrapVue tables to 
break](https://github.com/jenkinsci/dependency-track-plugin/blob/cc5f1bb8900f201384f05b633471dbd7ca48c69a/src/main/webapp/js/result-action.js#L6).


-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/jenkins/push/refs/heads/master/09a643-31d1ff%40github.com.

Reply via email to