Branch: refs/heads/master
Home: https://github.com/jenkinsci/hashicorp-vault-plugin
Commit: 5a1eedadbde028ac133764c83bbd2c7af5098b00
https://github.com/jenkinsci/hashicorp-vault-plugin/commit/5a1eedadbde028ac133764c83bbd2c7af5098b00
Author: Kyle Cronin <cro...@users.noreply.github.com>
Date: 2020-10-06 (Tue, 06 Oct 2020)
Changed paths:
M .gitignore
A
src/main/java/com/datapipe/jenkins/vault/credentials/AbstractAuthenticatingVaultTokenCredential.java
M
src/main/java/com/datapipe/jenkins/vault/credentials/VaultAppRoleCredential.java
M
src/main/java/com/datapipe/jenkins/vault/credentials/VaultGCPCredential.java
M
src/main/java/com/datapipe/jenkins/vault/credentials/VaultGithubTokenCredential.java
M
src/main/java/com/datapipe/jenkins/vault/credentials/VaultKubernetesCredential.java
M
src/main/java/com/datapipe/jenkins/vault/credentials/VaultTokenCredential.java
A
src/main/java/com/datapipe/jenkins/vault/credentials/common/AbstractVaultBaseStandardCredentials.java
M
src/main/java/com/datapipe/jenkins/vault/credentials/common/VaultHelper.java
M
src/main/java/com/datapipe/jenkins/vault/credentials/common/VaultSSHUserPrivateKeyImpl.java
M
src/main/java/com/datapipe/jenkins/vault/credentials/common/VaultStringCredentialImpl.java
M
src/main/java/com/datapipe/jenkins/vault/credentials/common/VaultUsernamePasswordCredentialImpl.java
A
src/main/resources/com/datapipe/jenkins/vault/configuration/VaultConfiguration/help-namespace.html
M
src/main/resources/com/datapipe/jenkins/vault/credentials/VaultAppRoleCredential/credentials.jelly
A
src/main/resources/com/datapipe/jenkins/vault/credentials/VaultAppRoleCredential/help-namespace.html
M
src/main/resources/com/datapipe/jenkins/vault/credentials/VaultGCPCredential/credentials.jelly
A
src/main/resources/com/datapipe/jenkins/vault/credentials/VaultGCPCredential/help-namespace.html
M
src/main/resources/com/datapipe/jenkins/vault/credentials/VaultGithubTokenCredential/credentials.jelly
A
src/main/resources/com/datapipe/jenkins/vault/credentials/VaultGithubTokenCredential/help-namespace.html
M
src/main/resources/com/datapipe/jenkins/vault/credentials/VaultKubernetesCredential/credentials.jelly
A
src/main/resources/com/datapipe/jenkins/vault/credentials/VaultKubernetesCredential/help-namespace.html
M
src/main/resources/com/datapipe/jenkins/vault/credentials/VaultTokenCredential/credentials.jelly
A
src/main/resources/com/datapipe/jenkins/vault/credentials/VaultTokenCredential/help-namespace.html
M
src/main/resources/com/datapipe/jenkins/vault/credentials/VaultTokenFileCredential/credentials.jelly
A
src/main/resources/com/datapipe/jenkins/vault/credentials/VaultTokenFileCredential/help-namespace.html
M
src/main/resources/com/datapipe/jenkins/vault/credentials/common/VaultSSHUserPrivateKeyImpl/credentials.jelly
A
src/main/resources/com/datapipe/jenkins/vault/credentials/common/VaultSSHUserPrivateKeyImpl/help-namespace.html
A
src/main/resources/com/datapipe/jenkins/vault/credentials/common/VaultSSHUserPrivateKeyImpl/help-path.html
A
src/main/resources/com/datapipe/jenkins/vault/credentials/common/VaultSSHUserPrivateKeyImpl/help-prefixPath.html
M
src/main/resources/com/datapipe/jenkins/vault/credentials/common/VaultStringCredentialImpl/credentials.jelly
A
src/main/resources/com/datapipe/jenkins/vault/credentials/common/VaultStringCredentialImpl/help-namespace.html
A
src/main/resources/com/datapipe/jenkins/vault/credentials/common/VaultStringCredentialImpl/help-path.html
A
src/main/resources/com/datapipe/jenkins/vault/credentials/common/VaultStringCredentialImpl/help-prefixPath.html
M
src/main/resources/com/datapipe/jenkins/vault/credentials/common/VaultUsernamePasswordCredentialImpl/credentials.jelly
A
src/main/resources/com/datapipe/jenkins/vault/credentials/common/VaultUsernamePasswordCredentialImpl/help-namespace.html
A
src/main/resources/com/datapipe/jenkins/vault/credentials/common/VaultUsernamePasswordCredentialImpl/help-path.html
A
src/main/resources/com/datapipe/jenkins/vault/credentials/common/VaultUsernamePasswordCredentialImpl/help-prefixPath.html
A
src/test/java/com/datapipe/jenkins/vault/credentials/AbstractAuthenticatingVaultTokenCredentialTest.java
M
src/test/java/com/datapipe/jenkins/vault/it/VaultTokenCredentialBindingIT.java
Log Message:
-----------
Namespace and prefix path support on credentials (#129)
* Namespace and prefix path support on credentials
Add "namespace" and "prefixPath" configuration options to all vault credential
types (string/username password/ssh).
Add "namespace" configuration option to vault auth credentials to handle case
where auth provider is mounted
in a different namespace (i.e. root) than the credential.
Add missing getters on vault credentials so they are
displayed in the ui forms.
* fix: Remove redundant null check
* chore: refactor auth token namespace management
Introduce new AbstractAuthenticatingVaultTokenCredential. This specialization
of the AbstractVaultTokenCredential is specific to vault credential types that
retrieve the auth client token by using one of the vault auth login methods.
This new abstraction takes care of two issues from the previous implementation:
1. the auth namespace property only applies to auth methods that use it (i.e.
VaultTokenCredential should not inherit that property).
2. the auth namespace can be safely scoped to the auth client and not effect
the underlying VaultConfig namespace setting.
* fix: invalid javadoc syntax
* chore: remove unused vault argument
The vault argument for the abstract getToken method is
not necessary, all the implementations use the provided
auth client.
* fix: remove unused imports
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/hashicorp-vault-plugin/push/refs/heads/master/3d36af-5a1eed%40github.com.
