Branch: refs/heads/master
Home: https://github.com/jenkinsci/envinject-plugin
Commit: b894af110d7f91f98ab1c1449f9503140af2793c
https://github.com/jenkinsci/envinject-plugin/commit/b894af110d7f91f98ab1c1449f9503140af2793c
Author: Kohsuke Kawaguchi <k...@kohsuke.org>
Date: 2013-08-08 (Thu, 08 Aug 2013)
Changed paths:
M src/main/java/org/jenkinsci/plugins/envinject/EnvInjectListener.java
M
src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectEnvVars.java
Log Message:
-----------
Masking the stack trace considered harmful
catching Throwable and eating its stack trace is really a bad idea as it
makes the error diagnostics impossible.
Please feel free to massage this change as you see fit, for example by
improving EnvInjectLogger, but please don't eat the exception stack
trace.
Just for your information, the current exception handling design in Jenkins is
roughly like this:
- InterruptedException and IOException are thrown everywhere
for remoting and process access, so we pretty much puts them
in the 'throws' clause for every method.
We do not try to wrap them into different exceptions.
- Whenever the caller can provide intermediate context,
IOException is caught and rewrapped into another IOException.
- AbortException is used a special subtype of IOException
where printing the error message is unnecessary. Core
handles this differently.
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
