Branch: refs/heads/misc/JENKINS-62389_ack-bundle-warning
Home: https://github.com/jenkinsci/google-play-android-publisher-plugin
Commit: 5debb2b83624699fd992cc253f03b1d053136a38
https://github.com/jenkinsci/google-play-android-publisher-plugin/commit/5debb2b83624699fd992cc253f03b1d053136a38
Author: Christopher Orr <ch...@orr.me.uk>
Date: 2020-05-21 (Thu, 21 May 2020)
Changed paths:
M
src/main/java/org/jenkinsci/plugins/googleplayandroidpublisher/ApkUploadTask.java
Log Message:
-----------
Show the size in the console log for each file being uploaded.
Commit: a96e24715fae32b1b8f5f4349d97e06975ed1efd
https://github.com/jenkinsci/google-play-android-publisher-plugin/commit/a96e24715fae32b1b8f5f4349d97e06975ed1efd
Author: Christopher Orr <ch...@orr.me.uk>
Date: 2020-05-21 (Thu, 21 May 2020)
Changed paths:
M
src/main/java/org/jenkinsci/plugins/googleplayandroidpublisher/ApkUploadTask.java
M
src/test/java/org/jenkinsci/plugins/googleplayandroidpublisher/ApkPublisherTest.java
Log Message:
-----------
Acknowledge the vague "bundle installation warning" for bundle uploads.
A user was having their upload rejected by Google Play when using this
plugin with a bundle file of around 200MB:
The installation of the app bundle may be too large and trigger user
warning on some devices, and this needs to be explicitly acknowledged
in the request.
Indeed, the API provides an `ackBundleInstallationWarning` flag in order
to acknowledge this when uploading a bundle. However, I wasn't able to
find any other reference to this "user warning" in the Google Play docs.
There _is_ a reference to a warning dialog, though it explicitly relates
to APKs rather than bundles, and encourages developers to switch to AAB:
https://support.google.com/googleplay/android-developer/answer/2481797
If the compressed size of your APK at the time of download (including
expansion files) is larger than 100MB, users see a warning dialog
suggesting that they use Wi-Fi to download your app.
Now we acknowledge this flag for all bundles, regardless of file size,
as setting the flag even for very small bundles seems to work fine.
i.e. users of this plugin who wish to upload large bundles should not
have to change their job config, and uploading should now succeed.
See https://issues.jenkins-ci.org/browse/JENKINS-62389 for details.
Commit: f990481f778c57a3965ff8b3dd93c2ae3c20c196
https://github.com/jenkinsci/google-play-android-publisher-plugin/commit/f990481f778c57a3965ff8b3dd93c2ae3c20c196
Author: Christopher Orr <ch...@orr.me.uk>
Date: 2020-05-21 (Thu, 21 May 2020)
Changed paths:
M README.md
Log Message:
-----------
Add note to README about bundle size warnings and their acknowledgement.
Compare:
https://github.com/jenkinsci/google-play-android-publisher-plugin/compare/5debb2b83624%5E...f990481f778c
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/google-play-android-publisher-plugin/push/refs/heads/misc/JENKINS-62389_ack-bundle-warning/000000-f99048%40github.com.
