Branch: refs/heads/fix/allow-rollout-variables
Home: https://github.com/jenkinsci/google-play-android-publisher-plugin
Commit: 23325148eb6c5d1110620ab78b41031987d39808
https://github.com/jenkinsci/google-play-android-publisher-plugin/commit/23325148eb6c5d1110620ab78b41031987d39808
Author: Christopher Orr <ch...@orr.me.uk>
Date: 2020-05-13 (Wed, 13 May 2020)
Changed paths:
M
src/main/java/org/jenkinsci/plugins/googleplayandroidpublisher/ApkPublisher.java
Log Message:
-----------
Fix incorrect input shown when no mapping files are found.
Commit: 8bdc5000712625acf726a8f60bb8cde3ef77d0f2
https://github.com/jenkinsci/google-play-android-publisher-plugin/commit/8bdc5000712625acf726a8f60bb8cde3ef77d0f2
Author: Christopher Orr <ch...@orr.me.uk>
Date: 2020-05-13 (Wed, 13 May 2020)
Changed paths:
M
src/main/java/org/jenkinsci/plugins/googleplayandroidpublisher/ApkPublisher.java
M
src/main/java/org/jenkinsci/plugins/googleplayandroidpublisher/GooglePlayBuildStepDescriptor.java
M
src/main/resources/org/jenkinsci/plugins/googleplayandroidpublisher/ApkPublisher/config.jelly
R
src/main/resources/org/jenkinsci/plugins/googleplayandroidpublisher/ApkPublisher/help-rolloutPercent.html
A
src/main/resources/org/jenkinsci/plugins/googleplayandroidpublisher/ApkPublisher/help-rolloutPercentage.html
Log Message:
-----------
Revert to using a string field for rollout percentage.
In the latest release, I deprecated the `rolloutPercentage` string field
and replaced it with the numeric `rolloutPercent` field in order to make
Pipeline configuration a bit less awkward, e.g.
`rolloutPercent: 12.34` instead of `rolloutPercentage: '12.34'`
However, while I tested build parameters with other fields, I didn't do
so for rollout percentage. This means that if you enter a variable as
the rollout percentage, e.g. `${ROLLOUT_PCT}`, Jenkins would attempt to
coerce this to a Double value when saving the job, which apparently does
not crash, but instead returns `null`.
Since we interpret `null` to mean "the default value", entering a
variable into the rollout percentage field, saving the job, and then
opening the job config again would show "100.0" as the value. Oops.
Now we've returned to `rolloutPercentage` being the default field, and
have marked `rolloutPercent` as deprecated.
However, we remain backwards compatible, and the `rolloutPercent` field
persisted for Freestyle jobs will be migrated back to the string value.
You can also continue to use the slightly more convenient numeric syntax
for Pipeline jobs — either field is accepted, with `rolloutPercentage`
taking precedence.
Commit: 800446280ed08098b4121ec509f6f5b048724c84
https://github.com/jenkinsci/google-play-android-publisher-plugin/commit/800446280ed08098b4121ec509f6f5b048724c84
Author: Christopher Orr <ch...@orr.me.uk>
Date: 2020-05-13 (Wed, 13 May 2020)
Changed paths:
M
src/test/java/org/jenkinsci/plugins/googleplayandroidpublisher/ApkPublisherTest.java
Log Message:
-----------
Add test case to verify that the config form can be roundtripped.
This includes providing a variable as the rollout percentage value,
rather than a numeric value, as this should now work again.
Commit: d604d98c3aaa624de1f67dd49ef9779317834c54
https://github.com/jenkinsci/google-play-android-publisher-plugin/commit/d604d98c3aaa624de1f67dd49ef9779317834c54
Author: Christopher Orr <ch...@orr.me.uk>
Date: 2020-05-13 (Wed, 13 May 2020)
Changed paths:
M
src/test/java/org/jenkinsci/plugins/googleplayandroidpublisher/ApkPublisherTest.java
Log Message:
-----------
Add test case to verify that variables are correctly handled at runtime.
All test configuration fields accept variables, and so their values
should be correctly expanded and used during a build.
Compare:
https://github.com/jenkinsci/google-play-android-publisher-plugin/compare/23325148eb6c%5E...d604d98c3aaa
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/google-play-android-publisher-plugin/push/refs/heads/fix/allow-rollout-variables/000000-d604d9%40github.com.
