Branch: refs/heads/master
Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin
Commit: 8d6d7c94c2b567aa76a60df48d9078b4175a24be
https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/8d6d7c94c2b567aa76a60df48d9078b4175a24be
Author: Pavel Roskin <[email protected]>
Date: 2019-12-16 (Mon, 16 Dec 2019)
Changed paths:
M
src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java
Log Message:
-----------
StashRepository: Format timestamps using DateTimeFormatter
DateTimeFormatter appeared in Java 8. The formatter is thread-safe, so it
can be initialized once.
Commit: 7567bfb03936cb471346aa6276d2341d41fbf938
https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/7567bfb03936cb471346aa6276d2341d41fbf938
Author: Pavel Roskin <[email protected]>
Date: 2019-12-16 (Mon, 16 Dec 2019)
Changed paths:
M
src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java
M src/spotbugs/excludesFilter.xml
Log Message:
-----------
StashRepository: Remove PRMC_POSSIBLY_REDUNDANT_METHOD_CALLS suppression
SpotBugs assumes incorrectly that logTimestamp() would always return the
same value. However, it doesn't consider multiple ZonedDateTime.now()
calls as "redundant".
While it might be possible to pass ZonedDateTime.now() as an argument to
logTimestamp(), that method would become too simple to be useful.
Replace calls to logTimestamp() with direct formatting calls.
Compare:
https://github.com/jenkinsci/stash-pullrequest-builder-plugin/compare/aa0b429956e9...7567bfb03936
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/aa0b42-7567bf%40github.com.
