Branch: refs/heads/master
Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin
Commit: bf508bf1e579c9fd293da102577f5cd26babfe90
https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/bf508bf1e579c9fd293da102577f5cd26babfe90
Author: Pavel Roskin <plros...@gmail.com>
Date: 2019-11-29 (Fri, 29 Nov 2019)
Changed paths:
M
src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClient.java
M
src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashApiClientTest.java
Log Message:
-----------
StashApiClient: Run HTTP requests in the main thread (#137)
* StashApiClient: Run HTTP requests in the main thread
Using separate threads adds complexity for little benefit. Socket timeout
should take care of slow HTTP connections.
JENKINS-30558 doesn't provide any evidence that a separate timeout for
requests was needed. The request timeout and the socket timeout were added
in the same commit 80431f422dce9ea763e59c28e35fef75113203b1.
This change eliminates ExecutionException as an exception thrown by
StashApiClient, replacing it with more specific exceptions. Update unit
tests for the new behavior.
* StashApiClient: Declare httpTask and thread where they are initialized
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/dc86da-bf508b%40github.com.
