Branch: refs/heads/master
Home: https://github.com/jenkinsci/jenkins
Commit: b7027563fe61453b49e8e866919fdf6447737b7b
https://github.com/jenkinsci/jenkins/commit/b7027563fe61453b49e8e866919fdf6447737b7b
Author: Kohsuke Kawaguchi <[email protected]>
Date: 2013-06-12 (Wed, 12 Jun 2013)
Changed paths:
M test/src/test/java/hudson/model/QueueTest.java
Log Message:
-----------
how Jesse finds all the typos, I have no idea
Commit: ec91933fc3ccf75c6fed9d64afb823c39be0b076
https://github.com/jenkinsci/jenkins/commit/ec91933fc3ccf75c6fed9d64afb823c39be0b076
Author: Kohsuke Kawaguchi <[email protected]>
Date: 2013-06-12 (Wed, 12 Jun 2013)
Changed paths:
M core/src/main/java/hudson/model/AbstractProject.java
M core/src/main/java/jenkins/security/ProjectAuthenticator.java
M core/src/main/java/jenkins/security/ProjectAuthenticatorConfiguration.java
Log Message:
-----------
Minor edits based on review comments
Commit: e3a1a78f6d71bfdd9560607ef4ef93ca7296ff67
https://github.com/jenkinsci/jenkins/commit/e3a1a78f6d71bfdd9560607ef4ef93ca7296ff67
Author: Kohsuke Kawaguchi <[email protected]>
Date: 2013-06-12 (Wed, 12 Jun 2013)
Changed paths:
M core/src/main/java/hudson/model/AbstractProject.java
M core/src/main/java/hudson/model/Executor.java
M core/src/main/java/hudson/model/Node.java
M core/src/main/java/hudson/model/Queue.java
M core/src/main/java/hudson/model/queue/AbstractQueueTask.java
M core/src/main/java/hudson/model/queue/AbstractSubTask.java
M core/src/main/java/hudson/model/queue/MappingWorksheet.java
M core/src/main/java/hudson/model/queue/QueueTaskFilter.java
M core/src/main/java/hudson/model/queue/SubTask.java
M core/src/main/java/hudson/model/queue/Tasks.java
R core/src/main/java/jenkins/security/ProjectAuthenticator.java
R core/src/main/java/jenkins/security/ProjectAuthenticatorConfiguration.java
R core/src/main/java/jenkins/security/ProjectAuthenticatorDescriptor.java
A core/src/main/java/jenkins/security/QueueItemAuthenticator.java
A
core/src/main/java/jenkins/security/QueueItemAuthenticatorConfiguration.java
A core/src/main/java/jenkins/security/QueueItemAuthenticatorDescriptor.java
R
core/src/main/resources/jenkins/security/ProjectAuthenticator/config.groovy
R
core/src/main/resources/jenkins/security/ProjectAuthenticatorConfiguration/config.groovy
A
core/src/main/resources/jenkins/security/QueueItemAuthenticator/config.groovy
A
core/src/main/resources/jenkins/security/QueueItemAuthenticatorConfiguration/config.groovy
M test/src/test/java/hudson/model/QueueTest.java
Log Message:
-----------
ProjectAuthenticator -> QueueItemAuthenticator
As Jesse pointed out, contextual information is often useful in authenticating
the build, which means we need to take Queue.Item (initially AbstractBuild was
the parameter, which provided the context, and I failed to accommodate that in
transition to AbstractProject.)
To still allow Queue.Tasks to provide a meaningful value fallback to
Queue.Task.getDefaultAuthentication() as opposed to hard code it to ACL.SYSTEM.
This allow plugins like remote-terminal-access to supply a meaningful secure
value without forcing a configuration change to the user.
Compare:
https://github.com/jenkinsci/jenkins/compare/48be96865fcd...e3a1a78f6d71
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
