[jenkinsci/influxdb-plugin] 35bb93: Remove feature to replace dashes with underscores

Aleksi Simell Wed, 13 Nov 2019 01:05:04 -0800

  Branch: refs/heads/development

  Home:   https://github.com/jenkinsci/influxdb-plugin


  Commit: 35bb93e6d854fe4dd71cf6a64ffcffc2a44d25f7

      
https://github.com/jenkinsci/influxdb-plugin/commit/35bb93e6d854fe4dd71cf6a64ffcffc2a44d25f7

  Author: René Scheibe <rene.sche...@gmail.com>

  Date:   2019-10-29 (Tue, 29 Oct 2019)



  Changed paths:

    M README.md

    M doc/img/advanced-options.png

    M src/main/java/jenkinsci/plugins/influxdb/InfluxDbPublicationService.java

    M src/main/java/jenkinsci/plugins/influxdb/InfluxDbPublisher.java

    M src/main/java/jenkinsci/plugins/influxdb/InfluxDbStep.java

    M src/main/java/jenkinsci/plugins/influxdb/InfluxDbStepExecution.java

    M 
src/main/java/jenkinsci/plugins/influxdb/generators/AbstractPointGenerator.java

    M 
src/main/java/jenkinsci/plugins/influxdb/generators/ChangeLogPointGenerator.java

    M 
src/main/java/jenkinsci/plugins/influxdb/generators/CoberturaPointGenerator.java

    M 
src/main/java/jenkinsci/plugins/influxdb/generators/CustomDataMapPointGenerator.java

    M 
src/main/java/jenkinsci/plugins/influxdb/generators/CustomDataPointGenerator.java

    M 
src/main/java/jenkinsci/plugins/influxdb/generators/JacocoPointGenerator.java

    M 
src/main/java/jenkinsci/plugins/influxdb/generators/JenkinsBasePointGenerator.java

    M 
src/main/java/jenkinsci/plugins/influxdb/generators/PerfPublisherPointGenerator.java

    M 
src/main/java/jenkinsci/plugins/influxdb/generators/PerformancePointGenerator.java

    M 
src/main/java/jenkinsci/plugins/influxdb/generators/RobotFrameworkPointGenerator.java

    M 
src/main/java/jenkinsci/plugins/influxdb/generators/SonarQubePointGenerator.java

    M src/main/java/jenkinsci/plugins/influxdb/global/GlobalRunListener.java

    M src/main/java/jenkinsci/plugins/influxdb/renderer/ProjectNameRenderer.java

    M 
src/main/resources/jenkinsci/plugins/influxdb/InfluxDbPublisher/config.jelly

    R 
src/main/resources/jenkinsci/plugins/influxdb/InfluxDbPublisher/help-replaceDashWithUnderscore.html

    M src/main/resources/jenkinsci/plugins/influxdb/InfluxDbStep/config.jelly

    R 
src/main/resources/jenkinsci/plugins/influxdb/InfluxDbStep/help-replaceDashWithUnderscore.html

    M 
src/test/java/jenkinsci/plugins/influxdb/generators/CustomDataMapPointGeneratorTest.java

    M 
src/test/java/jenkinsci/plugins/influxdb/generators/CustomDataPointGeneratorTest.java

    M 
src/test/java/jenkinsci/plugins/influxdb/generators/JenkinsBasePointGeneratorTest.java

    M 
src/test/java/jenkinsci/plugins/influxdb/generators/PerfPublisherPointGeneratorTest.java

    M 
src/test/java/jenkinsci/plugins/influxdb/generators/SonarQubePointGeneratorTest.java



  Log Message:

  -----------

  Remove feature to replace dashes with underscores



Why

---

- It is possible to have dashes in InfluxDB.

- Dashes have not been consistently replaced with underscores.



Writing data

------------

There is no mention of dashes regarding a special handling in the line protocol:

- 
https://docs.influxdata.com/influxdb/v1.7/write_protocols/line_protocol_reference/

- 
https://docs.influxdata.com/influxdb/v1.7/write_protocols/line_protocol_tutorial/



Therefore dashes can just be used as is.



Reading data

------------

Dashes are interpreted as binary operators in the query language:

- https://docs.influxdata.com/influxdb/v1.7/query_language/spec/



Therefore identifiers that contain dashes have to be quoted with double quotes.



Summary of changes

------------------

- `AbstractPointGenerator`

  - fix project name creation

  - now supporting a custom project name even if not replacing dashes with 
underscores

- `InfluxDbStep`

   - marking the option `replaceDashWithUnderscore` as deprecated and ignoring 
it

   - only logging a warning in the pipeline output, not to break pipelines by 
completely removing this option

- `InfluxDbPublisher`

  - removing the option `replaceDashWithUnderscore` from the UI

  - the option can be removed via "Manage Old Data" from the config

- adjusted screenshot without the removed option

- consistent naming of `ProjectNameRenderer` instance





  Commit: 46261ec78ae40f671861349645e4b733bc1d866b

      
https://github.com/jenkinsci/influxdb-plugin/commit/46261ec78ae40f671861349645e4b733bc1d866b

  Author: Aleksi Simell <aleksi.sim...@eficode.com>

  Date:   2019-11-13 (Wed, 13 Nov 2019)



  Changed paths:

    M README.md

    M doc/img/advanced-options.png

    M src/main/java/jenkinsci/plugins/influxdb/InfluxDbPublicationService.java

    M src/main/java/jenkinsci/plugins/influxdb/InfluxDbPublisher.java

    M src/main/java/jenkinsci/plugins/influxdb/InfluxDbStep.java

    M src/main/java/jenkinsci/plugins/influxdb/InfluxDbStepExecution.java

    M 
src/main/java/jenkinsci/plugins/influxdb/generators/AbstractPointGenerator.java

    M 
src/main/java/jenkinsci/plugins/influxdb/generators/ChangeLogPointGenerator.java

    M 
src/main/java/jenkinsci/plugins/influxdb/generators/CoberturaPointGenerator.java

    M 
src/main/java/jenkinsci/plugins/influxdb/generators/CustomDataMapPointGenerator.java

    M 
src/main/java/jenkinsci/plugins/influxdb/generators/CustomDataPointGenerator.java

    M 
src/main/java/jenkinsci/plugins/influxdb/generators/JacocoPointGenerator.java

    M 
src/main/java/jenkinsci/plugins/influxdb/generators/JenkinsBasePointGenerator.java

    M 
src/main/java/jenkinsci/plugins/influxdb/generators/PerfPublisherPointGenerator.java

    M 
src/main/java/jenkinsci/plugins/influxdb/generators/PerformancePointGenerator.java

    M 
src/main/java/jenkinsci/plugins/influxdb/generators/RobotFrameworkPointGenerator.java

    M 
src/main/java/jenkinsci/plugins/influxdb/generators/SonarQubePointGenerator.java

    M src/main/java/jenkinsci/plugins/influxdb/global/GlobalRunListener.java

    M src/main/java/jenkinsci/plugins/influxdb/renderer/ProjectNameRenderer.java

    M 
src/main/resources/jenkinsci/plugins/influxdb/InfluxDbPublisher/config.jelly

    R 
src/main/resources/jenkinsci/plugins/influxdb/InfluxDbPublisher/help-replaceDashWithUnderscore.html

    M src/main/resources/jenkinsci/plugins/influxdb/InfluxDbStep/config.jelly

    R 
src/main/resources/jenkinsci/plugins/influxdb/InfluxDbStep/help-replaceDashWithUnderscore.html

    M 
src/test/java/jenkinsci/plugins/influxdb/generators/CustomDataMapPointGeneratorTest.java

    M 
src/test/java/jenkinsci/plugins/influxdb/generators/CustomDataPointGeneratorTest.java

    M 
src/test/java/jenkinsci/plugins/influxdb/generators/JenkinsBasePointGeneratorTest.java

    M 
src/test/java/jenkinsci/plugins/influxdb/generators/PerfPublisherPointGeneratorTest.java

    M 
src/test/java/jenkinsci/plugins/influxdb/generators/SonarQubePointGeneratorTest.java



  Log Message:

  -----------

  Merge pull request #85 from darxriggs/remove-dash-replacement



Remove feature to replace dashes with underscores





Compare: 
https://github.com/jenkinsci/influxdb-plugin/compare/c57e27e639ed...46261ec78ae4

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/influxdb-plugin/push/refs/heads/development/c57e27-46261e%40github.com.

[jenkinsci/influxdb-plugin] 35bb93: Remove feature to replace dashes with underscores

Reply via email to