Branch: refs/heads/master
Home: https://github.com/jenkinsci/acceptance-test-harness
Commit: 4812e6c22ba2947f990c4effeec65c337fdd7c68
https://github.com/jenkinsci/acceptance-test-harness/commit/4812e6c22ba2947f990c4effeec65c337fdd7c68
Author: Oliver Gondža <ogon...@gmail.com>
Date: 2019-10-14 (Mon, 14 Oct 2019)
Changed paths:
M src/main/java/org/jenkinsci/test/acceptance/po/WizardCustomizeJenkins.java
Log Message:
-----------
Fail fast on plugin install failure
Commit: c96d2c48a205f0d1f37ea78c52c02ff6c4aa6cbb
https://github.com/jenkinsci/acceptance-test-harness/commit/c96d2c48a205f0d1f37ea78c52c02ff6c4aa6cbb
Author: Oliver Gondža <ogon...@gmail.com>
Date: 2019-10-15 (Tue, 15 Oct 2019)
Changed paths:
M
src/main/java/org/jenkinsci/test/acceptance/controller/LocalController.java
M src/main/java/org/jenkinsci/test/acceptance/junit/WithInstallWizard.java
M
src/main/java/org/jenkinsci/test/acceptance/machine/RemoteJenkinsProvider.java
Log Message:
-----------
Do not install form-element-path for tests annotated with @WithInstallWizard
Early installation of form-element-path causes to install implied dependencies
- in version that was detached. This can easily cause such plugin need to be
updated
for other plugins to install correctly. While Plugin Manager is ready for this
and
handle it well, Setup Wizard is reporting an issue and demand Jenkins to be
restarted.
Note its page objects _can_ be made more robust to restart if needed, but since
it would happen every time, it would just obscure real issues this can detect.
Not
to mention this is running Setup Wizard out of its expected mode of execution,
as
it does not expect any plugins to be present effectively testing corner case
rather
that main code paths.
Alternative approach used in the past was bumping form-element-path every time
plugin gets detached from core so it never have any implied dependencies to
cause
problems. But the downside is someone has to update that plugin every time there
is a plugin detached from core, and it prevents the plugin load for older cores
making older cores essentially untestable with ATH!
This is essentially taking a trade-off of never using form-element-path for
wizard
tests over getting them broken every so often _and_ restricting ATH usage to
quite
recent cores.
Commit: 0bbb7a52f1698816f536d7ec1d4a36bff05ea9a4
https://github.com/jenkinsci/acceptance-test-harness/commit/0bbb7a52f1698816f536d7ec1d4a36bff05ea9a4
Author: Oliver Gondža <ogon...@gmail.com>
Date: 2019-10-16 (Wed, 16 Oct 2019)
Changed paths:
M
src/main/java/org/jenkinsci/test/acceptance/controller/LocalController.java
M src/main/java/org/jenkinsci/test/acceptance/junit/WithInstallWizard.java
M
src/main/java/org/jenkinsci/test/acceptance/machine/RemoteJenkinsProvider.java
M src/main/java/org/jenkinsci/test/acceptance/po/WizardCustomizeJenkins.java
Log Message:
-----------
Merge pull request #544 from jenkinsci/fix-wizard-install
Do not install form-element-path for tests annotated with @WithInstallWizard
Compare:
https://github.com/jenkinsci/acceptance-test-harness/compare/10d7dae64ae4...0bbb7a52f169
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/acceptance-test-harness/push/refs/heads/master/10d7da-0bbb7a%40github.com.
