Branch: refs/heads/master

  Home:   https://github.com/jenkinsci/cloudbees-jenkins-advisor-plugin

  Commit: f6691689a79efa49accb1e2ae2528745038d066e

      
https://github.com/jenkinsci/cloudbees-jenkins-advisor-plugin/commit/f6691689a79efa49accb1e2ae2528745038d066e

  Author: Arnaud Héritier <aherit...@apache.org>

  Date:   2019-10-15 (Tue, 15 Oct 2019)



  Changed paths:

    M 
src/main/java/com/cloudbees/jenkins/plugins/advisor/client/AdvisorClient.java

    R src/main/java/com/cloudbees/jenkins/plugins/advisor/client/FileHelper.java

    A src/main/java/com/cloudbees/jenkins/plugins/advisor/utils/FileHelper.java



  Log Message:

  -----------

  [JENKINS-59767] [cleanup] Move FileHelper with others helpers under utils 
package





  Commit: 8c87d77edc52b28d01a297525cdd913ffc8a88fe

      
https://github.com/jenkinsci/cloudbees-jenkins-advisor-plugin/commit/8c87d77edc52b28d01a297525cdd913ffc8a88fe

  Author: Arnaud Héritier <aherit...@apache.org>

  Date:   2019-10-15 (Tue, 15 Oct 2019)



  Changed paths:

    M 
src/main/java/com/cloudbees/jenkins/plugins/advisor/AdvisorGlobalConfiguration.java

    M 
src/main/java/com/cloudbees/jenkins/plugins/advisor/utils/EmailValidator.java

    M 
src/test/java/com/cloudbees/jenkins/plugins/advisor/utils/EmailValidatorTest.java



  Log Message:

  -----------

  [JENKINS-59767] [cleanup] EmailValidator should not be instantiated like 
others utility classes





  Commit: b742569c060a58b79c799259e06b053c84d52c89

      
https://github.com/jenkinsci/cloudbees-jenkins-advisor-plugin/commit/b742569c060a58b79c799259e06b053c84d52c89

  Author: Arnaud Héritier <aherit...@apache.org>

  Date:   2019-10-15 (Tue, 15 Oct 2019)



  Changed paths:

    M 
src/main/java/com/cloudbees/jenkins/plugins/advisor/AdvisorGlobalConfiguration.java

    M 
src/main/java/com/cloudbees/jenkins/plugins/advisor/utils/EmailValidator.java

    R 
src/main/java/com/cloudbees/jenkins/plugins/advisor/utils/FormValidationHelper.java



  Log Message:

  -----------

  [JENKINS-59767] [cleanup] Merge FormValidationHelper into EmailValidator





  Commit: f512c960dd2aa464808f2378db674e70509e27c6

      
https://github.com/jenkinsci/cloudbees-jenkins-advisor-plugin/commit/f512c960dd2aa464808f2378db674e70509e27c6

  Author: Arnaud Héritier <aherit...@apache.org>

  Date:   2019-10-15 (Tue, 15 Oct 2019)



  Changed paths:

    M 
src/main/resources/com/cloudbees/jenkins/plugins/advisor/AdvisorGlobalConfiguration/index.jelly



  Log Message:

  -----------

  [JENKINS-59767] [cleanup] Rework the UI to better match Jenkins best 
practices for advanced options





  Commit: 75d4da8d8c48748b4deb2a0519535d8651370d1a

      
https://github.com/jenkinsci/cloudbees-jenkins-advisor-plugin/commit/75d4da8d8c48748b4deb2a0519535d8651370d1a

  Author: Arnaud Héritier <aherit...@apache.org>

  Date:   2019-10-15 (Tue, 15 Oct 2019)



  Changed paths:

    M 
src/main/java/com/cloudbees/jenkins/plugins/advisor/AdvisorGlobalConfiguration.java

    M 
src/main/resources/com/cloudbees/jenkins/plugins/advisor/AdvisorGlobalConfiguration/index.jelly

    M 
src/test/java/com/cloudbees/jenkins/plugins/advisor/AdvisorGlobalConfigurationTest.java



  Log Message:

  -----------

  [JENKINS-59767] [cleanup] doTestSendEmail doesn't not send any email to CCs





  Commit: eb9fd4ba53bf91634dfd39d091aa58b3d3aa2d4d

      
https://github.com/jenkinsci/cloudbees-jenkins-advisor-plugin/commit/eb9fd4ba53bf91634dfd39d091aa58b3d3aa2d4d

  Author: Arnaud Héritier <aherit...@apache.org>

  Date:   2019-10-15 (Tue, 15 Oct 2019)



  Changed paths:

    M 
src/main/java/com/cloudbees/jenkins/plugins/advisor/AdvisorGlobalConfiguration.java

    M 
src/main/resources/com/cloudbees/jenkins/plugins/advisor/AdvisorGlobalConfiguration/index.jelly

    M 
src/test/java/com/cloudbees/jenkins/plugins/advisor/AdvisorGlobalConfigurationTest.java



  Log Message:

  -----------

  [JENKINS-59767] [task] We shouldn't allow to send a test email from the 
server without validation the TOS





  Commit: b1b02874398b0ba58042afc5e25fa4f2538e726f

      
https://github.com/jenkinsci/cloudbees-jenkins-advisor-plugin/commit/b1b02874398b0ba58042afc5e25fa4f2538e726f

  Author: Arnaud Héritier <aherit...@apache.org>

  Date:   2019-10-15 (Tue, 15 Oct 2019)



  Changed paths:

    M 
src/main/java/com/cloudbees/jenkins/plugins/advisor/client/AdvisorClientConfig.java



  Log Message:

  -----------

  [JENKINS-59767] [cleanup] We shouldn't add the cc parameter if it's blank





  Commit: e6795ceac8a21d2c74a45763209fc8587ebcc8a3

      
https://github.com/jenkinsci/cloudbees-jenkins-advisor-plugin/commit/e6795ceac8a21d2c74a45763209fc8587ebcc8a3

  Author: Arnaud Héritier <aherit...@apache.org>

  Date:   2019-10-15 (Tue, 15 Oct 2019)



  Changed paths:

    M 
src/main/java/com/cloudbees/jenkins/plugins/advisor/AdvisorGlobalConfiguration.java



  Log Message:

  -----------

  [JENKINS-59767] [cleanup] The health check does not require any email





  Commit: ed104faa48ad62635af7200a79c8c3f89bae9714

      
https://github.com/jenkinsci/cloudbees-jenkins-advisor-plugin/commit/ed104faa48ad62635af7200a79c8c3f89bae9714

  Author: Arnaud Héritier <aherit...@apache.org>

  Date:   2019-10-15 (Tue, 15 Oct 2019)



  Changed paths:

    M 
src/main/java/com/cloudbees/jenkins/plugins/advisor/AdvisorGlobalConfiguration.java

    M src/main/resources/lib/advisor/validateOnLoad.jelly

    M 
src/test/java/com/cloudbees/jenkins/plugins/advisor/AdvisorGlobalConfigurationTest.java



  Log Message:

  -----------

  [JENKINS-59767] [cleanup] doTestConnection is not used.



validateServerConnection is replacing it and our tests should validate it.





  Commit: 6671991144c4b59e648663873ebb9e99d7f55ede

      
https://github.com/jenkinsci/cloudbees-jenkins-advisor-plugin/commit/6671991144c4b59e648663873ebb9e99d7f55ede

  Author: Arnaud Héritier <aherit...@apache.org>

  Date:   2019-10-15 (Tue, 15 Oct 2019)



  Changed paths:

    M 
src/main/java/com/cloudbees/jenkins/plugins/advisor/AdvisorGlobalConfiguration.java

    M 
src/main/java/com/cloudbees/jenkins/plugins/advisor/utils/EmailValidator.java

    M 
src/test/java/com/cloudbees/jenkins/plugins/advisor/AdvisorGlobalConfigurationTest.java

    M 
src/test/java/com/cloudbees/jenkins/plugins/advisor/utils/EmailValidatorTest.java



  Log Message:

  -----------

  [JENKINS-59767] [cleanup] Move validations logic in EmailValidator





  Commit: 8d7b52341bdf8066d35075fbbb8865c5cdebf524

      
https://github.com/jenkinsci/cloudbees-jenkins-advisor-plugin/commit/8d7b52341bdf8066d35075fbbb8865c5cdebf524

  Author: Arnaud Héritier <aherit...@apache.org>

  Date:   2019-10-15 (Tue, 15 Oct 2019)



  Changed paths:

    M 
src/main/java/com/cloudbees/jenkins/plugins/advisor/AdvisorGlobalConfiguration.java

    M 
src/main/java/com/cloudbees/jenkins/plugins/advisor/casc/AdvisorRootConfigurator.java

    M 
src/main/java/com/cloudbees/jenkins/plugins/advisor/utils/EmailValidator.java

    M 
src/test/java/com/cloudbees/jenkins/plugins/advisor/BundleUploadMonitorTest.java

    M src/test/java/com/cloudbees/jenkins/plugins/advisor/BundleUploadTest.java



  Log Message:

  -----------

  [JENKINS-59767] [task] Remove the `isValid` configuration field and compute 
it when required





  Commit: 55eece3d7b15b64341826faff6cff83454cb28d5

      
https://github.com/jenkinsci/cloudbees-jenkins-advisor-plugin/commit/55eece3d7b15b64341826faff6cff83454cb28d5

  Author: Arnaud Héritier <aherit...@apache.org>

  Date:   2019-10-15 (Tue, 15 Oct 2019)



  Changed paths:

    M src/main/resources/lib/advisor/validateOnLoad.jelly



  Log Message:

  -----------

  [JENKINS-59767] [cleanup] Avoid hardcoded Strings



j:getStatic doesn't not work in every cases thus apply the hack from 
https://issues.jenkins-ci.org/browse/JENKINS-26579





  Commit: 1e42930604034b0db658bd95936b80434d2b444d

      
https://github.com/jenkinsci/cloudbees-jenkins-advisor-plugin/commit/1e42930604034b0db658bd95936b80434d2b444d

  Author: Arnaud Héritier <aherit...@apache.org>

  Date:   2019-10-15 (Tue, 15 Oct 2019)



  Changed paths:

    M 
src/main/java/com/cloudbees/jenkins/plugins/advisor/AdvisorGlobalConfiguration.java

    M 
src/main/java/com/cloudbees/jenkins/plugins/advisor/casc/AdvisorRootConfigurator.java

    M src/test/java/com/cloudbees/jenkins/plugins/advisor/BundleUploadTest.java



  Log Message:

  -----------

  [JENKINS-59767] [cleanup] Remove useless imports





  Commit: 0cc3d34df3a7bf7c42a8fb82e7fac461ef339e8b

      
https://github.com/jenkinsci/cloudbees-jenkins-advisor-plugin/commit/0cc3d34df3a7bf7c42a8fb82e7fac461ef339e8b

  Author: Arnaud Héritier <aherit...@apache.org>

  Date:   2019-10-15 (Tue, 15 Oct 2019)



  Changed paths:

    M 
src/main/java/com/cloudbees/jenkins/plugins/advisor/casc/AdvisorRootConfigurator.java

    M 
src/test/java/com/cloudbees/jenkins/plugins/advisor/casc/AdvisorRootConfiguratorTest.java



  Log Message:

  -----------

  [JENKINS-59767] [task] Use constants for fields names





  Commit: 2ee22324cdbe25c421854d78ca111a37fd8d3ce7

      
https://github.com/jenkinsci/cloudbees-jenkins-advisor-plugin/commit/2ee22324cdbe25c421854d78ca111a37fd8d3ce7

  Author: Arnaud Héritier <aherit...@apache.org>

  Date:   2019-10-15 (Tue, 15 Oct 2019)



  Changed paths:

    M 
src/test/java/com/cloudbees/jenkins/plugins/advisor/casc/AdvisorRootConfiguratorTest.java



  Log Message:

  -----------

  [JENKINS-59767] [task] Simple checks are sometimes the most useful



(especially before big a refactoring)





Compare: 
https://github.com/jenkinsci/cloudbees-jenkins-advisor-plugin/compare/b3e4ccd960f7...2ee22324cdbe

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/cloudbees-jenkins-advisor-plugin/push/refs/heads/master/b3e4cc-2ee223%40github.com.

Reply via email to