Branch: refs/heads/master Home: https://github.com/jenkinsci/docker-plugin Commit: 48bd3b55c6d2152b87b29faf4877c882c1282eb8 https://github.com/jenkinsci/docker-plugin/commit/48bd3b55c6d2152b87b29faf4877c882c1282eb8 Author: Peter Darton <pjdar...@users.noreply.github.com> Date: 2019-09-16 (Mon, 16 Sep 2019)
Changed paths: M src/main/java/com/nirima/jenkins/plugins/docker/utils/PortUtils.java M src/main/resources/io/jenkins/docker/connector/DockerComputerSSHConnector/help-maxNumRetries.html M src/main/resources/io/jenkins/docker/connector/DockerComputerSSHConnector/help-retryWaitTime.html M src/test/java/com/nirima/jenkins/plugins/docker/utils/PortUtilsTest.java Log Message: ----------- PortUtils "retries" field was actually used as "tries" (#718) * PortUtils.ConnectionCheck's "retries" field was being used as if it were a "number of tries" field rather than "number of retries", meaning that a figure of zero meant "don't try at all, just fail". * The "retryDelay" delay was being done even on the final attempt, whereas the code should only wait between attempts. * UI help text updated to match change in meaning. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/docker-plugin/push/refs/heads/master/91d8c7-48bd3b%40github.com.