Branch: refs/heads/master
Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin
Commit: 2961b06f6f5854593608705ce5bd2525a2745349
https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/2961b06f6f5854593608705ce5bd2525a2745349
Author: Pavel Roskin <plros...@gmail.com>
Date: 2019-06-03 (Mon, 03 Jun 2019)
Changed paths:
M
src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepository.java
M
src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepositoryTest.java
Log Message:
-----------
StashRepository: Clean up comment sorting, add comments
When extracting parameters from comments, start with the oldest comments,
as the code iterates over all comments. Parameters from the new comments
are processed last, overwriting older values.
When deleting old "BUILD FINISHED" comments, don't sort the comments, it
doesn't matter in which order they are deleted.
When looking for comments to decide whether to run a build, start with
the most recent comments. The loop terminates early as soon as it's clear
whether to start the build or not. Don't sort and reverse the sort order
as two operations, use reverse sorting.
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/db3937-2961b0%40github.com.
For more options, visit https://groups.google.com/d/optout.
