Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 47c6fa4e7314d7d0d1d49e82b45a91072e804499 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/47c6fa4e7314d7d0d1d49e82b45a91072e804499 Author: Pavel Roskin <plros...@gmail.com> Date: 2019-05-24 (Fri, 24 May 2019)
Changed paths: M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepositoryTest.java Log Message: ----------- StashRepositoryTest: Remove verifications Verifications require mock objects, but we can easily use real objects to represent the data received from the Bitbucket Server. The existing verifications don't provide any significant value. Commit: 12077ff8b8246d3dbc7e24b7b1d0ccf664fdbfa2 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/12077ff8b8246d3dbc7e24b7b1d0ccf664fdbfa2 Author: Pavel Roskin <plros...@gmail.com> Date: 2019-05-24 (Fri, 24 May 2019) Changed paths: M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepositoryTest.java Log Message: ----------- StashRepositoryTest: Replace "CLOSED" with "MERGED" "MERGED" is an actual PR status (the others are "OPEN" and "DECLINED"). It's easier to understand tests based on realistic data. Commit: 79d6c7d2e7b9325dbebaa24f8f57e8bb4df64e00 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/79d6c7d2e7b9325dbebaa24f8f57e8bb4df64e00 Author: Pavel Roskin <plros...@gmail.com> Date: 2019-05-24 (Fri, 24 May 2019) Changed paths: M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepositoryTest.java Log Message: ----------- StashRepositoryTest: Refactor creation of a pull request list Commit: a38b1d1a8da7e85f7e81035808a792607bd0bbf2 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/a38b1d1a8da7e85f7e81035808a792607bd0bbf2 Author: Pavel Roskin <plros...@gmail.com> Date: 2019-05-24 (Fri, 24 May 2019) Changed paths: M src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/StashRepositoryTest.java Log Message: ----------- StashRepositoryTest: Don't mock pullRequest, repository and repoRepo They are just data classes that can be trivially constructed and modified. That allows refactoring some code shared between test cases. Compare: https://github.com/jenkinsci/stash-pullrequest-builder-plugin/compare/41f8d12de895...a38b1d1a8da7 -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/41f8d1-a38b1d%40github.com. For more options, visit https://groups.google.com/d/optout.