Branch: refs/heads/master Home: https://github.com/jenkinsci/google-compute-engine-plugin Commit: fa8333bfda32588267e06aa4a9128865a5fe4a8b https://github.com/jenkinsci/google-compute-engine-plugin/commit/fa8333bfda32588267e06aa4a9128865a5fe4a8b Author: Stephen Shank <stephensh...@google.com> Date: 2019-04-17 (Wed, 17 Apr 2019)
Changed paths: M pom.xml R src/test/java/com/google/jenkins/plugins/computeengine/ComputeEngineCloudIT.java A src/test/java/com/google/jenkins/plugins/computeengine/integration/ComputeClientIT.java A src/test/java/com/google/jenkins/plugins/computeengine/integration/ComputeEngineCloud1WorkerCreatedFor2ExecutorsIT.java A src/test/java/com/google/jenkins/plugins/computeengine/integration/ComputeEngineCloudMultipleLabelsIT.java A src/test/java/com/google/jenkins/plugins/computeengine/integration/ComputeEngineCloudNoSnapshotCreatedIT.java A src/test/java/com/google/jenkins/plugins/computeengine/integration/ComputeEngineCloudOneShotInstanceIT.java A src/test/java/com/google/jenkins/plugins/computeengine/integration/ComputeEngineCloudSnapshotCreatedIT.java A src/test/java/com/google/jenkins/plugins/computeengine/integration/ComputeEngineCloudTemplateIT.java A src/test/java/com/google/jenkins/plugins/computeengine/integration/ComputeEngineCloudTemplateNoGoogleLabelsIT.java A src/test/java/com/google/jenkins/plugins/computeengine/integration/ComputeEngineCloudWorkerCreatedIT.java A src/test/java/com/google/jenkins/plugins/computeengine/integration/ComputeEngineCloudWorkerFailedIT.java A src/test/java/com/google/jenkins/plugins/computeengine/integration/ITUtil.java Log Message: ----------- Parallelized Integration Tests (#60) * WIP Parallelized integration tests. * Set concurrency in pom properties. * Add license headers for new files. * Inline old helper methods. * Run maven fmt on new classes. * Factor out project ID and credentials as constants. * Factor out init method into individual methods for separate concerns. * Add note addresssing 'delete' string in getLabel. * Add newline after if blocks. * Refactor WorkerCreatedTest to test individual behaviors in separate methods. Use cloud returned by init method. Put wait into BeforeClass for MultipleLabels test. * Remove timeouts from test methods for MultipleLabels test. * Split config label and cloud ID tests as well. * Fix method name typo. * Move timeouts to class rules. * Fix formatting. * Create IT class for testWorkerFailed, remove from ComputeEngineCloudIT. * Add IT class for testOneShotInstance, remove from ComputeEngineCloudIT * Add IT class for testTemplate, remove from ComputeEngineCloudIT. * Add IT Class for testTemplateNoGoogleLabels, remove from ComputeEngineCloudIT * Add IT class for testNoShapshotCreated, remove from ComputeEngineCloudIT. In order to handle snapshot logs, turn off parallel methods and add handling for ComputeEngineInstance log message." * Add IT class for testSnapshotCreated, remove from ComputeEngineCloudIT. * Use static imports where possible for ITUtil. * Make 1WorkerCreatedFor2Executors match the other tests in putting most setup in init and including multiple tests. * Add missing license headers. * Replace testGetCredentials with assertion in initCredentials. Remove everything no longer needed from ComputeEngineCloudIT and rename to ComputeClientIT with 1 remaining test. * Code cleanup. Resolve unchecked NPE warnings from IntelliJ. * Rename variables in integration tests for readability. * Add ComputeClientIT to same directory as other integration tests. * Use descriptive variable names in ComputeClientIT. Use ITUtil as much as possible in ComputeClientIT. Run formatter on ComputeClientIT. * Replace initLogging with using handleClassLogs where needed, construct StreamHandler at declaration. * Rename ITUtil::teardown to teardownResources and use as static import throughout. * Remove unneeded comments, inline some constant strings and string variables that are only used once. Make use of builder when creating instance configuration. * Add test to oneshot IT to verify that the node no longer exists in GCP, independent of being removed from Jenkins. * Rename handleClassLogs -> addClassLogHandler * Add test verifying that the Oneshot instance was deleted from GCP after the snapshot was created. * Add test assertion for image status * Remove extra logging statement * Remove usages of logs for assertion message output. * Remove all usages of log aggregation and testing with those aggregated logs. * Inline constant that is not needed anymore * Clarify naming of MultipleLabels tests, add test for instance status. Remove unneeded comments. * Rework No Snapshot Created Tests. Make sure that the instance is stopped but no snapshot is created, move waiting to test methods. * Add status check test methods where missing and relevant. * Add javadoc headers to all IT related classes. * Fix javadoc style with mvn format. * Deduplicate assertions. * PR Feedback: Proper method header comments, remove extra newline, remove extra static field. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.