Branch: refs/heads/master
Home: https://github.com/jenkinsci/gradle-jpi-plugin
Commit: aed966a68c8a4b091fe6f8a306b94803ceab90af
https://github.com/jenkinsci/gradle-jpi-plugin/commit/aed966a68c8a4b091fe6f8a306b94803ceab90af
Author: Steve Hill <sghill....@gmail.com>
Date: 2019-03-30 (Sat, 30 Mar 2019)
Changed paths:
M CHANGELOG.md
M src/main/groovy/org/jenkinsci/gradle/plugins/jpi/JpiPlugin.groovy
M src/test/groovy/org/jenkinsci/gradle/plugins/jpi/JpiPluginSpec.groovy
Log Message:
-----------
Add jar deps to testImplementation
- Previously added to testCompile configuration
- Gradle 3.4 was released on 2017-02-20 with the testImplementation
configuration[1]
- Gradle 4.7 was released on 2018-04-18 with a userguide specifying
the testCompile configuration is deprecated[2]
[1]:
https://docs.gradle.org/3.4/release-notes.html#configurations-can-be-unresolvable
[2]:
https://docs.gradle.org/4.7/userguide/java_plugin.html#sec:java_plugin_and_dependency_management
Commit: a05240ba974be00061b6f29c19c2642d7e1a60d9
https://github.com/jenkinsci/gradle-jpi-plugin/commit/a05240ba974be00061b6f29c19c2642d7e1a60d9
Author: Steve Hill <sghill....@gmail.com>
Date: 2019-03-30 (Sat, 30 Mar 2019)
Changed paths:
M CHANGELOG.md
M src/main/groovy/org/jenkinsci/gradle/plugins/jpi/JpiPlugin.groovy
M
src/test/groovy/org/jenkinsci/gradle/plugins/jpi/AbstractManifestIntegrationSpec.groovy
A
src/test/groovy/org/jenkinsci/gradle/plugins/jpi/AddedDependenciesIntegrationSpec.groovy
M src/test/groovy/org/jenkinsci/gradle/plugins/jpi/JpiPluginSpec.groovy
A src/test/groovy/org/jenkinsci/gradle/plugins/jpi/TestDataGenerator.groovy
R
src/test/groovy/org/jenkinsci/gradle/plugins/jpi/TestDependenciesTaskIntegrationSpec.groovy
R
src/test/resources/org/jenkinsci/gradle/plugins/jpi/resolveTestDependencies.gradle
Log Message:
-----------
Add plugin jars using Configuration#withDependencies
- Moving the flaky test that checked testCompileClasspath had the right
jar dependencies to GradleTestKit revealed that the resolved
dependencies required configurations to be resolved in a certain order
that Gradle could not guarantee. This was fixed by using the
Configuration#withDependencies api that has been present since Gradle
4.4.
- The referenced test fails quite often on at least one of four CI nodes,
causing the build to appear unstable. The problem looks to be that
we're forcing resolution through the ProjectBuilder api. Using
GradleTestKit is expected to be more stable because Gradle is allowed
to do resolution as it will in practice.
- Each added dependency now has a reason using the because api present
since Gradle 4.6.
- TestDependenciesTaskIntegrationSpec was renamed to
AddedDependenciesIntegrationSpec and now has both tests related to the
dependencies the plugin is adding.
Compare:
https://github.com/jenkinsci/gradle-jpi-plugin/compare/f5a514aaebcc...a05240ba974b
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
