Branch: refs/heads/master
Home: https://github.com/jenkinsci/gradle-jpi-plugin
Commit: 0cc4b42794003ee66631c71430c98fd2c005224a
https://github.com/jenkinsci/gradle-jpi-plugin/commit/0cc4b42794003ee66631c71430c98fd2c005224a
Author: Steve Hill <sghill....@gmail.com>
Date: 2019-03-25 (Mon, 25 Mar 2019)
Changed paths:
M CHANGELOG.md
M build.gradle
M src/main/groovy/org/jenkinsci/gradle/plugins/jpi/JpiManifest.groovy
A
src/main/java/org/jenkinsci/gradle/plugins/jpi/internal/VersionCalculator.java
A
src/test/groovy/org/jenkinsci/gradle/plugins/jpi/AbstractManifestIntegrationSpec.groovy
A
src/test/groovy/org/jenkinsci/gradle/plugins/jpi/JarManifestIntegrationSpec.groovy
A
src/test/groovy/org/jenkinsci/gradle/plugins/jpi/JpiManifestIntegrationSpec.groovy
R src/test/groovy/org/jenkinsci/gradle/plugins/jpi/JpiManifestSpec.groovy
A
src/test/groovy/org/jenkinsci/gradle/plugins/jpi/internal/VersionCalculatorTest.groovy
R src/test/resources/org/jenkinsci/gradle/plugins/jpi/basics.mf
R
src/test/resources/org/jenkinsci/gradle/plugins/jpi/compatible-since-version.mf
R
src/test/resources/org/jenkinsci/gradle/plugins/jpi/complex-dependencies.mf
R src/test/resources/org/jenkinsci/gradle/plugins/jpi/dependencies.mf
R src/test/resources/org/jenkinsci/gradle/plugins/jpi/dependency.mf
R src/test/resources/org/jenkinsci/gradle/plugins/jpi/mask-classes.mf
R
src/test/resources/org/jenkinsci/gradle/plugins/jpi/optional-dependencies.mf
R src/test/resources/org/jenkinsci/gradle/plugins/jpi/optional-dependency.mf
R src/test/resources/org/jenkinsci/gradle/plugins/jpi/plugin-class.mf
R src/test/resources/org/jenkinsci/gradle/plugins/jpi/plugin-developer.mf
R src/test/resources/org/jenkinsci/gradle/plugins/jpi/plugin-developers.mf
R
src/test/resources/org/jenkinsci/gradle/plugins/jpi/plugin-first-class-loader.mf
R src/test/resources/org/jenkinsci/gradle/plugins/jpi/sandbox-status.mf
R
src/test/resources/org/jenkinsci/gradle/plugins/jpi/support-dynamic-loading-maybe.mf
R
src/test/resources/org/jenkinsci/gradle/plugins/jpi/support-dynamic-loading-no.mf
R
src/test/resources/org/jenkinsci/gradle/plugins/jpi/support-dynamic-loading-yes.mf
R
src/test/resources/org/jenkinsci/gradle/plugins/jpi/support-dynamic-loading/maybe/hudson.Extension
R
src/test/resources/org/jenkinsci/gradle/plugins/jpi/support-dynamic-loading/no/hudson.Extension
R
src/test/resources/org/jenkinsci/gradle/plugins/jpi/support-dynamic-loading/yes/hudson.Extension
R src/test/resources/org/jenkinsci/gradle/plugins/jpi/test.mf
Log Message:
-----------
GradleTestKit for ManifestSpec
- Eliminate the use of ProjectBuilder in favor of running these tests
through GradleTestKit to ensure the entire workflow is working
- Run each test on the jar task and jpi task, checking the resulting
jar or plugin manifest for the expected entries
- Introduce commons-text so we can randomly generate project names and
versions in tests. The goal of this is to more clearly illustrate
the mapping and rely less on hardcoded strings that are easily missed
- Define the default scenario in one test and use subsequent tests to
set up the minimum inputs to produce the desired outputs
- Removes the full manifest test resources. This style meant that adding
a new manifest entry was very high-touch - 19 tests failed when adding
the new Minimum-Java-Version field, which would have resulted in
changing many files. By switching to this approach, our eventual change
to add Java-Minimum-Version will only need to add a dedicated test and
update the defaults test
- Extract VersionCalculator so its appending behavior can be
independently unit-tested
- Update the format of the appended timestamp to be ISO8601 so it
is not timezone dependent, clearly indicates the timezone it was
generated in, and conflict resolves correctly when resolved through
gradle
- Change format of Supports-Dynamic-Loading tests to compile a simple
plugin through gradle with the expected annotation rather than checking
in the encoded value of hudson.Extension
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
