Branch: refs/heads/java-minimum-version
Home: https://github.com/jenkinsci/gradle-jpi-plugin
Commit: 2da115fe12747b2f26b77122ef4be080fbf98042
https://github.com/jenkinsci/gradle-jpi-plugin/commit/2da115fe12747b2f26b77122ef4be080fbf98042
Author: Steve Hill <sghill....@gmail.com>
Date: 2019-03-23 (Sat, 23 Mar 2019)
Changed paths:
M build.gradle
A
src/test/groovy/org/jenkinsci/gradle/plugins/jpi/JarManifestIntegrationSpec.groovy
M src/test/groovy/org/jenkinsci/gradle/plugins/jpi/JpiManifestSpec.groovy
R src/test/resources/org/jenkinsci/gradle/plugins/jpi/basics.mf
Log Message:
-----------
Split JpiManifestSpec#basics into 3 tests
- Introduce JarManifestIntegrationSpec to more clearly separate the
kinds of tests that are setting up build files and invoking gradle
over using ProjectBuilder and directly instantiating tasks
- Introduce commons-text so we can randomly generate project names and
versions in tests. The goal of this is to more clearly illustrate
the mapping and rely less on hardcoded strings that are easily missed
- #basics test #1 now has a build file that defines nothing other than a
version and name, and asserts on the complete manifest in the
generated jar
- #basics test #2 defines a group in the buildfile and ensures this is
mapped to the 'Group-Id' manifest entry
- #basics test #3 adds a jenkinsPlugin.coreVersion and ensures this is
mapped to the 'Jenkins-Version' manifest entry
- Removes the basics.mf test resource that was previously used to test
these 3 scenarios at once. This style meant that adding a new manifest
entry was very high-touch - 19 tests failed when adding the field,
which would have resulted in changing many files. By switching to this
approach, our eventual change to add Java-Minimum-Version will only
need to add a dedicated test and update the defaults test
Commit: 8ea9d1e559db4c686598342351180978aa13effa
https://github.com/jenkinsci/gradle-jpi-plugin/commit/8ea9d1e559db4c686598342351180978aa13effa
Author: Steve Hill <sghill....@gmail.com>
Date: 2019-03-23 (Sat, 23 Mar 2019)
Changed paths:
M
src/test/groovy/org/jenkinsci/gradle/plugins/jpi/JarManifestIntegrationSpec.groovy
M src/test/groovy/org/jenkinsci/gradle/plugins/jpi/JpiManifestSpec.groovy
Log Message:
-----------
Move #'JAR contains manifest' to integration test
- Place Plugin implementation in package and assert it is discovered
correctly
Commit: a6c03c6e7bb62aa0af0b227d8f4e1a9328773f87
https://github.com/jenkinsci/gradle-jpi-plugin/commit/a6c03c6e7bb62aa0af0b227d8f4e1a9328773f87
Author: Steve Hill <sghill....@gmail.com>
Date: 2019-03-23 (Sat, 23 Mar 2019)
Changed paths:
A
src/test/groovy/org/jenkinsci/gradle/plugins/jpi/AbstractManifestIntegrationSpec.groovy
M
src/test/groovy/org/jenkinsci/gradle/plugins/jpi/JarManifestIntegrationSpec.groovy
A
src/test/groovy/org/jenkinsci/gradle/plugins/jpi/JpiManifestIntegrationSpec.groovy
M src/test/groovy/org/jenkinsci/gradle/plugins/jpi/JpiManifestSpec.groovy
R src/test/resources/org/jenkinsci/gradle/plugins/jpi/test.mf
Log Message:
-----------
Introduce JpiManifestIntegrationSpec
- Remove test.mf in favor of running all the manifest generation specs
for both the jar task and jpi task
- These tests are expected to produce the same outputs in both cases
with only the task name and output file varying so far. Introduce an
abstract class with two abstract methods for these properties to
more clearly define that we expect the same results in both places
Commit: 1a7456af2bfa6c7efe367e82b07e7b3ad8b3c889
https://github.com/jenkinsci/gradle-jpi-plugin/commit/1a7456af2bfa6c7efe367e82b07e7b3ad8b3c889
Author: Steve Hill <sghill....@gmail.com>
Date: 2019-03-23 (Sat, 23 Mar 2019)
Changed paths:
M
src/test/groovy/org/jenkinsci/gradle/plugins/jpi/AbstractManifestIntegrationSpec.groovy
M src/test/groovy/org/jenkinsci/gradle/plugins/jpi/JpiManifestSpec.groovy
Log Message:
-----------
Move task caching tests to AbstractManifest..Spec
Commit: 363b15effcc5dad3fce7d1ff1292160ce096a2ae
https://github.com/jenkinsci/gradle-jpi-plugin/commit/363b15effcc5dad3fce7d1ff1292160ce096a2ae
Author: Steve Hill <sghill....@gmail.com>
Date: 2019-03-23 (Sat, 23 Mar 2019)
Changed paths:
M src/test/groovy/org/jenkinsci/gradle/plugins/jpi/JpiManifestSpec.groovy
R src/test/resources/org/jenkinsci/gradle/plugins/jpi/plugin-class.mf
Log Message:
-----------
Remove JpiManifestSpec#plugin-class
- Already covered by the IntegrationTest 'should populate Plugin-Class
from legacy hudson.Plugin implementation'
Commit: 5a35c148692eab1f89fd0405b5829506d86c9b9d
https://github.com/jenkinsci/gradle-jpi-plugin/commit/5a35c148692eab1f89fd0405b5829506d86c9b9d
Author: Steve Hill <sghill....@gmail.com>
Date: 2019-03-23 (Sat, 23 Mar 2019)
Changed paths:
M CHANGELOG.md
M src/main/groovy/org/jenkinsci/gradle/plugins/jpi/JpiManifest.groovy
A
src/main/java/org/jenkinsci/gradle/plugins/jpi/internal/VersionCalculator.java
M
src/test/groovy/org/jenkinsci/gradle/plugins/jpi/AbstractManifestIntegrationSpec.groovy
M src/test/groovy/org/jenkinsci/gradle/plugins/jpi/JpiManifestSpec.groovy
A
src/test/groovy/org/jenkinsci/gradle/plugins/jpi/internal/VersionCalculatorTest.groovy
Log Message:
-----------
Move the JpiManifest#no version test to integration
- Extract VersionCalculator so its appending behavior can be
independently unit-tested
- Update the format of the appended timestamp to be ISO8601 so it
is not timezone dependent, clearly indicates the timezone it was
generated in, and conflict resolves correctly when resolved through
gradle
Compare:
https://github.com/jenkinsci/gradle-jpi-plugin/compare/2da115fe1274%5E...5a35c148692e
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
