Branch: refs/heads/master Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin Commit: 276204d08b3530ddce282071eece98051a654550 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/276204d08b3530ddce282071eece98051a654550 Author: Pavel Roskin <plros...@gmail.com> Date: 2019-03-20 (Wed, 20 Mar 2019)
Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTrigger.java M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashPullRequestsBuilder.java Log Message: ----------- [JENKINS-56349] Make StashPullRequestsBuilder constructor take two arguments Call that constructor from StashBuildTrigger#start() instead of using setters. Check that project is not null before passing it to the StashPullRequestsBuilder constructor. Remove setters from StashPullRequestsBuilder, they are not used anymore. Commit: c00035088572a5c4ff28f10c9c0eaf1714dc9d06 https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/c00035088572a5c4ff28f10c9c0eaf1714dc9d06 Author: Pavel Roskin <plros...@gmail.com> Date: 2019-03-20 (Wed, 20 Mar 2019) Changed paths: M src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/StashBuildTrigger.java Log Message: ----------- [JENKINS-56349] Protect StashBuildTrigger#run() against crash if called early Trigger#run() can be called before Trigger#start() according to https://javadoc.jenkins.io/hudson/triggers/Trigger.html#run-- Improve the log message if the project is disabled. Lower the level to "fine", it should be clear why the disabled project is not building pull requests. Don't log anything when starting the build, the builder logs a similar message. Make stop() set the builder to null to revert the effect of start(). Compare: https://github.com/jenkinsci/stash-pullrequest-builder-plugin/compare/3e4b8f7f755a...c00035088572 -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.