Branch: refs/heads/master Home: https://github.com/jenkinsci/slack-plugin Commit: b3a926151572e25ba03c8d6829d94a60a261a57c https://github.com/jenkinsci/slack-plugin/commit/b3a926151572e25ba03c8d6829d94a60a261a57c Author: Steve Hill <sghill....@gmail.com> Date: 2019-02-16 (Sat, 16 Feb 2019)
Changed paths: M src/main/java/jenkins/plugins/slack/ActiveNotifier.java A src/main/java/jenkins/plugins/slack/JenkinsTokenExpander.java M src/main/java/jenkins/plugins/slack/SlackNotifier.java M src/main/java/jenkins/plugins/slack/StandardSlackService.java A src/main/java/jenkins/plugins/slack/TokenExpander.java A src/main/java/jenkins/plugins/slack/decisions/Condition.java A src/main/java/jenkins/plugins/slack/decisions/Context.java A src/main/java/jenkins/plugins/slack/decisions/NotificationConditions.java A src/main/java/jenkins/plugins/slack/decisions/OnAborted.java A src/main/java/jenkins/plugins/slack/decisions/OnBackToNormal.java A src/main/java/jenkins/plugins/slack/decisions/OnNotBuilt.java A src/main/java/jenkins/plugins/slack/decisions/OnRepeatedFailure.java A src/main/java/jenkins/plugins/slack/decisions/OnSingleFailure.java A src/main/java/jenkins/plugins/slack/decisions/OnSuccess.java A src/main/java/jenkins/plugins/slack/decisions/OnUnstable.java A src/main/java/jenkins/plugins/slack/logging/BuildAwareLogger.java A src/main/java/jenkins/plugins/slack/logging/BuildKey.java A src/main/java/jenkins/plugins/slack/logging/SlackNotificationsLogger.java M src/test/java/jenkins/plugins/slack/MessageBuilderEscapeTest.java A src/test/java/jenkins/plugins/slack/decisions/ContextTest.java A src/test/java/jenkins/plugins/slack/decisions/NotificationConditionsTest.java A src/test/java/jenkins/plugins/slack/decisions/OnBackToNormalTest.java A src/test/java/jenkins/plugins/slack/decisions/OnRepeatedFailureTest.java A src/test/java/jenkins/plugins/slack/decisions/OnSingleFailureTest.java A src/test/java/jenkins/plugins/slack/logging/SlackNotificationsLoggerTest.java M src/test/java/jenkins/plugins/slack/workflow/MessageBuilderTest.java Log Message: ----------- Add additional logging for notification conditions (#516) - Extracted Condition interface that let's us log both if the condition was met and if the user preference allowed the notification to be sent - Conditions that have interesting logic are unit-tested - Moves to the message supplier style of logging, which is not invoked unless that level of logging is enabled - Introduces a build key format - [ProjectFullDisplayName #<build>] to better indicate which build the messaging is coming from - Introduce SlackFactory in ActiveNotifier instead of passing in the dependencies to create a slack factory method - Introduce SlackNotificationsLogger - which writes to the system log with the build key embedded, and writes info-level messages to the build log with the plugin name embedded -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.