Branch: refs/heads/master Home: https://github.com/jenkinsci/scm-trait-commit-skip-plugin Commit: 6c9b9674f46de040eb4aa1c9d472d6736961ad2f https://github.com/jenkinsci/scm-trait-commit-skip-plugin/commit/6c9b9674f46de040eb4aa1c9d472d6736961ad2f Author: René Scheibe <rene.sche...@gmail.com> Date: 2018-12-19 (Wed, 19 Dec 2018)
Changed paths: M bitbucket-scm-trait-commit-skip/src/main/java/org/jenkinsci/plugins/scm_filter/BitbucketBranchCommitSkipTrait.java M bitbucket-scm-trait-commit-skip/src/main/java/org/jenkinsci/plugins/scm_filter/BitbucketCommitAuthorBranchBuildStrategy.java M bitbucket-scm-trait-commit-skip/src/main/java/org/jenkinsci/plugins/scm_filter/BitbucketCommitMessageBranchBuildStrategy.java M bitbucket-scm-trait-commit-skip/src/main/java/org/jenkinsci/plugins/scm_filter/BitbucketCommitSkipTrait.java M bitbucket-scm-trait-commit-skip/src/test/java/org/jenkinsci/plugins/scm_filter/BitbucketCommitSkipTraitTest.java M bitbucket-scm-trait-commit-skip/src/test/resources/org/jenkinsci/plugins/scm_filter/BitbucketCommitSkipTraitTest/skipci.xml M github-scm-trait-commit-skip/src/main/java/org/jenkinsci/plugins/scm_filter/GitHubBranchCommitSkipTrait.java M github-scm-trait-commit-skip/src/main/java/org/jenkinsci/plugins/scm_filter/GitHubCommitAuthorBranchBuildStrategy.java M github-scm-trait-commit-skip/src/main/java/org/jenkinsci/plugins/scm_filter/GitHubCommitMessageBranchBuildStrategy.java M github-scm-trait-commit-skip/src/main/java/org/jenkinsci/plugins/scm_filter/GitHubCommitSkipTrait.java M github-scm-trait-commit-skip/src/test/java/org/jenkinsci/plugins/scm_filter/GitHubCommitSkipTraitTest.java M pom.xml M scm-trait-commit-skip-common/pom.xml M scm-trait-commit-skip-common/src/main/java/org/jenkinsci/plugins/scm_filter/BranchCommitSkipTrait.java M scm-trait-commit-skip-common/src/main/java/org/jenkinsci/plugins/scm_filter/CommitSkipTrait.java A scm-trait-commit-skip-common/src/main/java/org/jenkinsci/plugins/scm_filter/ExcludeByMessageSCMHeadFilter.java Log Message: ----------- Code Improvements (#11) * Fix spelling * Remove unused imports * Simplify code using iterators by using foreach loops * Consistent formatting * Usie wiki.jenkins.io in plugin URL * Replace deprecated Hamcrest matcher * Make imports consistent * Reference inner class without outer class * Reduce visibility of internal classes There is no need to use them elsewhere. * Remove redundant empty constructors These default constructors are automatically generated. * Remove methods that just call their super method There is no need for them. They add no additional functionality. * Extract inner filter class into separate file * No need for @inheritDoc The javadoc tool has an algorithm to automatically inherit Javadoc. Have a look at this detailed example: https://dzone.com/articles/inheriting-javadoc-method-comments **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.