Branch: refs/heads/master
Home: https://github.com/jenkinsci/remoting
Commit: 89a51a0a712ae220f37a92cb7d0d86d2bfe7a851
https://github.com/jenkinsci/remoting/commit/89a51a0a712ae220f37a92cb7d0d86d2bfe7a851
Author: Jeff Thompson <jeffre...@gmail.com>
Date: 2018-09-19 (Wed, 19 Sep 2018)
Changed paths:
M src/main/java/org/jenkinsci/remoting/protocol/ProtocolStack.java
Log Message:
-----------
[JENKINS-53569] Remove unnecessary locking.
There is no indication that this section of code constitutes a critical
section. The only meaningful thing it does is atomic and is handled elsewhere
in the code by good design. The extra checks serve no significant purpose.
The code in Filter that calls this grabs a lock on Filter before it calls this
meaning that it already holds one lock. If another thread grabs the lock on
ProtocolStack before the Filter than a thread is always possible.
Probably more of the locks in this area should be cleaned up and the threading
/ locking model simplified.
Commit: 8fcc9a9eab747bc11efd8b05d5279f55a09007f2
https://github.com/jenkinsci/remoting/commit/8fcc9a9eab747bc11efd8b05d5279f55a09007f2
Author: Jeff Thompson <37345299+jeffre...@users.noreply.github.com>
Date: 2018-09-28 (Fri, 28 Sep 2018)
Changed paths:
M src/main/java/org/jenkinsci/remoting/protocol/ProtocolStack.java
Log Message:
-----------
Merge pull request #289 from jeffret-b/filterRemovalDeadlock
[JENKINS-53569] Remove unnecessary locking.
Compare:
https://github.com/jenkinsci/remoting/compare/b0fde3f1cc53...8fcc9a9eab74
**NOTE:** This service has been marked for deprecation:
https://developer.github.com/changes/2018-04-25-github-services-deprecation/
Functionality will be removed from GitHub.com on January 31st, 2019.
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
