Branch: refs/heads/refactoring
Home: https://github.com/jenkinsci/pipeline-github-plugin
Commit: 3925f92e2b7e79bc60255eee4d411475e6427aaa
https://github.com/jenkinsci/pipeline-github-plugin/commit/3925f92e2b7e79bc60255eee4d411475e6427aaa
Author: Aaron Whiteside <aaronjwhites...@gmail.com>
Date: 2018-02-28 (Wed, 28 Feb 2018)
Changed paths:
M README.md
M pom.xml
M
src/main/java/org/jenkinsci/plugins/pipeline/github/CommitFileGroovyObject.java
M
src/main/java/org/jenkinsci/plugins/pipeline/github/CommitGroovyObject.java
M
src/main/java/org/jenkinsci/plugins/pipeline/github/CommitStatusGroovyObject.java
M src/main/java/org/jenkinsci/plugins/pipeline/github/GitHubHelper.java
M
src/main/java/org/jenkinsci/plugins/pipeline/github/IssueCommentGroovyObject.java
M
src/main/java/org/jenkinsci/plugins/pipeline/github/PullRequestGroovyObject.java
M
src/main/java/org/jenkinsci/plugins/pipeline/github/ReviewCommentGroovyObject.java
M
src/main/java/org/jenkinsci/plugins/pipeline/github/client/ExtendedIssueService.java
M
src/main/java/org/jenkinsci/plugins/pipeline/github/client/ExtendedPullRequestService.java
Log Message:
-----------
Minor refactoring due to
https://jenkins.io/security/advisory/2017-07-10/#unsafe-methods-in-the-default-whitelist-in-script-security-plugin
ExtendedIssueService.java
ExtendedPullRequestService.java
- replaced varargs with `List`s
CommitFileGroovyObject.java
CommitGroovyObject.java
CommitStatusGroovyObject.java
IssueCommentGroovyObject.java
ReviewCommentGroovyObject.java
- converted all properties into bean style methods
- added @Whitelisted to the bean style methods
GitHubHelper.java
- no longer use the deprecated method `getScanCredentialsId()` in
`GitHubSCMSource`
PullRequestGroovyObject.java
- converted all properties into bean style methods
- added @Whitelisted to the bean style methods
- added missing `setAssignees()` method
- converted all varargs to `List`s
pom.xml
- bumped the projects major version, because the API changes are not backwards
compatible for existing pipelines
- bumped parent pom version
- bumped minimum jenkins version, latest LTS release
- bumped various dependencies
- added a missing test dependency
- removed redundant maven plugin definition, fixed with latest parent pom
version
README.md
- added usage examples for the trigger and `pullRequest` global variable in
both scripted and declarative pipeline styles
- updated documentation to match new bean style access instead of property
style access
- updated documentation to show `List` usage for setting collections instead of
varargs.
- fixed a few typos along the way
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
