Branch: refs/heads/master
Home: https://github.com/jenkinsci/jenkins
Commit: 30ab4481f286a5c33499489dfcb9b3df6587ff38
https://github.com/jenkinsci/jenkins/commit/30ab4481f286a5c33499489dfcb9b3df6587ff38
Author: Vincent Latombe <vinc...@latombe.net>
Date: 2017-12-10 (Sun, 10 Dec 2017)
Changed paths:
M core/src/main/java/hudson/util/PluginServletFilter.java
M core/src/main/java/jenkins/install/InstallState.java
M core/src/main/java/jenkins/install/InstallUtil.java
M core/src/main/java/jenkins/install/SetupWizard.java
M core/src/main/java/jenkins/model/Jenkins.java
A test/src/test/java/jenkins/install/SetupWizardRestartTest.java
Log Message:
-----------
[FIXES JENKINS-47439] Setup wizard does not resume after restart (#3166)
* [JENKINS-47439] Add a failing test
On first startup, the setup wizard goes into state NEW and the filter to
force display the setup wizard is installed.
On second startup, the setup wizard goes into state RESTART (which
assumes the setup wizard is done), and the setup wizard is skipped
completely.
This test expects that state NEW is retained upon restart when nothing
is done.
* [JENKINS-47439] Persist InstallState
In some cases, the heuristics to determine the current setup wizard state are
fragile. It is safer to persist the install state so that upon restart,
the setup wizard can resume where it was left off.
* Missing javadoc and since for new public methods
* s/XXX/FIXME/
* Missed that one
* Setup wizard filter should be removed when entering a state where setup is
complete
* Use parameterized logging
* Improvements over previous impl
* Removed static isUsingSecurityToken. Now only determined from install
state.
* Call onInstallStateUpdate before InstallState#initializeState as the
latter can update state.
* Triggering a new build
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
