Branch: refs/heads/master Home: https://github.com/jenkinsci/git-plugin Commit: d74750819e5a2ed5397763954d0a32d22d062f6d https://github.com/jenkinsci/git-plugin/commit/d74750819e5a2ed5397763954d0a32d22d062f6d Author: Jacob Keller <jacob.e.kel...@intel.com> Date: 2017-11-15 (Wed, 15 Nov 2017)
Changed paths: M src/main/java/hudson/plugins/git/extensions/impl/SubmoduleOption.java A src/test/java/hudson/plugins/git/extensions/impl/SubmoduleOptionTest.java Log Message: ----------- [JENKINS-31934] throw IOException around submodule update failures Updating the submodule can fail in a similar manner to git checkout of the parent project. If we simply throw the GitException, then the generic retry loop will not kick in. For now, the only exceptions we'll catch is the GitException which should be generated if the launchCommand fails. Without this change, intermittent failures when attempting to pull submodule data from a git remote will not properly allow the retry loop to kick in. Add a new test case to verify that we actually do throw the IOException. Because this exception case is likely due to an intermittent error, we'll use mocks to setup a case where we always throw the exception. Signed-off-by: Jacob Keller <jacob.e.kel...@intel.com> Commit: 35189dc35f35051a75d4cacb26d054cc2ec00e04 https://github.com/jenkinsci/git-plugin/commit/35189dc35f35051a75d4cacb26d054cc2ec00e04 Author: Mark Waite <mark.earl.wa...@gmail.com> Date: 2017-11-16 (Thu, 16 Nov 2017) Changed paths: M src/main/java/hudson/plugins/git/extensions/impl/SubmoduleOption.java A src/test/java/hudson/plugins/git/extensions/impl/SubmoduleOptionTest.java Log Message: ----------- Merge pull request #374 from jacob-keller/jk-submodule-io-exception git: throw IOException around submodule update failures Compare: https://github.com/jenkinsci/git-plugin/compare/5838c3c2a374...35189dc35f35 -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.