Branch: refs/heads/master Home: https://github.com/jenkinsci/pipeline-model-definition-plugin Commit: 73326536fc49dfcbb199f6926fd75f96e098b853 https://github.com/jenkinsci/pipeline-model-definition-plugin/commit/73326536fc49dfcbb199f6926fd75f96e098b853 Author: Andrew Bayer <andrew.ba...@gmail.com> Date: 2017-11-02 (Thu, 02 Nov 2017)
Changed paths: M pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/DescriptorLookupCache.java M pipeline-model-definition/pom.xml M pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/Utils.groovy M pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/validator/ModelValidatorImpl.groovy M pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/ValidatorTest.java A pipeline-model-definition/src/test/resources/errors/specificDescribableMatch.groovy M pom.xml Log Message: ----------- [FIXED JENKINS-47781] Narrow model lookups when appropriate The original problem here is that if you just look up describables by the "upstream" symbol, you'll get one from Copy Artifact before you get `ReverseBuildTrigger`. Which...ok. Except that our syntax checking treats kicks in for the one from Copy Artifact! So let's narrow our model lookups when appropriate. I don't *love* this solution - it could be smarter and have a better understanding of context. But this works for now, so I'll go with it. Commit: a8a3f4aed5c0a6523aea0fc2afd614f7ec74fa6b https://github.com/jenkinsci/pipeline-model-definition-plugin/commit/a8a3f4aed5c0a6523aea0fc2afd614f7ec74fa6b Author: Andrew Bayer <andrew.ba...@gmail.com> Date: 2017-11-02 (Thu, 02 Nov 2017) Changed paths: M pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/DescriptorLookupCache.java Log Message: ----------- Smarter null safety on symbol lookup Commit: 3d0be22796c151c0bed8c00dc9b08c39d35b2317 https://github.com/jenkinsci/pipeline-model-definition-plugin/commit/3d0be22796c151c0bed8c00dc9b08c39d35b2317 Author: Andrew Bayer <andrew.ba...@gmail.com> Date: 2017-11-03 (Fri, 03 Nov 2017) Changed paths: M pipeline-model-api/src/main/java/org/jenkinsci/plugins/pipeline/modeldefinition/DescriptorLookupCache.java M pipeline-model-definition/pom.xml M pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/Utils.groovy M pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/validator/ModelValidatorImpl.groovy M pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/ValidatorTest.java A pipeline-model-definition/src/test/resources/errors/specificDescribableMatch.groovy M pom.xml Log Message: ----------- Merge pull request #212 from abayer/jenkins-47781 [FIXED JENKINS-47781] Narrow model lookups when appropriate Compare: https://github.com/jenkinsci/pipeline-model-definition-plugin/compare/31c504aaffba...3d0be22796c1 -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.