Branch: refs/heads/master Home: https://github.com/jenkinsci/gerrit-trigger-plugin Commit: 6b28ce0abd571c8f9325df195f462862fed42540 https://github.com/jenkinsci/gerrit-trigger-plugin/commit/6b28ce0abd571c8f9325df195f462862fed42540 Author: Joe Hansche <jhans...@myyearbook.com> Date: 2012-02-28 (Tue, 28 Feb 2012)
Changed paths: M gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ParameterExpander.java M gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/model/BuildMemory.java M gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java M gerrithudsontrigger/src/main/resources/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger/config.jelly A gerrithudsontrigger/src/main/webapp/trigger/help-BuildUnsuccessfulFilepath.html M gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerTest.java M gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/mock/DuplicatesUtil.java Log Message: ----------- JENKINS-12881: Initial implementation Commit: f79e10be25028ad69a433a82b061ebc1bd6371d2 https://github.com/jenkinsci/gerrit-trigger-plugin/commit/f79e10be25028ad69a433a82b061ebc1bd6371d2 Author: Joe Hansche <jhans...@myyearbook.com> Date: 2012-02-28 (Tue, 28 Feb 2012) Changed paths: M gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ParameterExpander.java M gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ToGerritRunListener.java M gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/model/BuildMemory.java Log Message: ----------- JENKINS-12881: Obtain failure message at completed-time. Resolves a potential race condition when a single job may be executing multiple times before the change "batch" status is ready to be reported back to Gerrit. The test setup is: * Job-A - Shell: echo "Starting ${BUILD_TAG}" > error-message.txt sleep 5 - Shell: echo "Always fails ${BUILD_TAG}" > error-message.txt sleep 5 exit 1 * Job-B - Shell: echo "Starting ${BUILD_TAG}" > error-message.txt sleep 15 - Shell: echo "Never fails ${BUILD_TAG}" > error-message.txt sleep 15 Job-B will always be the long-pole (30 sec). Job-A will always fail, hopefully with "Always fails ______" as the error-message. Create 2 commits for review, and push both commits to Gerrit. Both Job-A builds will run and fail within 20 seconds, before the first Job-B build is even finished executing. The test is successful if both review commits contain the correct "Always fails {TAG}" messages, corresponding to the correct URL. The test fails if any other string exists in the failure message. Commit: 7e4c31972ba20d5b556a8d7f470f6e050998c1b4 https://github.com/jenkinsci/gerrit-trigger-plugin/commit/7e4c31972ba20d5b556a8d7f470f6e050998c1b4 Author: Joe Hansche <jhans...@myyearbook.com> Date: 2012-02-28 (Tue, 28 Feb 2012) Changed paths: M gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ToGerritRunListener.java M gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/model/BuildMemory.java Log Message: ----------- JENKINS-12881: Refactor the message retrieval Refactor at which point the message is retrieved, and which class is responsible for doing so. Should be more in line with the original intent of the classes, and not introduce a high degree of coupling. Commit: 2118649a59a7a3be1b787c650f21c21832ba6869 https://github.com/jenkinsci/gerrit-trigger-plugin/commit/2118649a59a7a3be1b787c650f21c21832ba6869 Author: Joe Hansche <jhans...@myyearbook.com> Date: 2012-02-29 (Wed, 29 Feb 2012) Changed paths: M gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ParameterExpander.java M gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ToGerritRunListener.java M gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/model/BuildMemory.java M gerrithudsontrigger/src/main/webapp/trigger/help-BuildUnsuccessfulFilepath.html Log Message: ----------- JENKINS-12881: Fixes per code review comments at pull request #12 Commit: 0cec882c6d52162dca2367ffa7e486cb061457a4 https://github.com/jenkinsci/gerrit-trigger-plugin/commit/0cec882c6d52162dca2367ffa7e486cb061457a4 Author: Joe Hansche <jhans...@myyearbook.com> Date: 2012-02-29 (Wed, 29 Feb 2012) Changed paths: M gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ParameterExpander.java M gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ToGerritRunListener.java M gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/model/BuildMemory.java M gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ParameterExpanderTest.java M gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ToGerritRunListenerTest.java M gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/mock/Setup.java Log Message: ----------- JENKINS-12881: Adds unit tests for failure-message feature Commit: 81f7aeaa165eead88f4e6c37b1ee2d313c4e8738 https://github.com/jenkinsci/gerrit-trigger-plugin/commit/81f7aeaa165eead88f4e6c37b1ee2d313c4e8738 Author: Robert Sandell <robert.sand...@sonyericsson.com> Date: 2012-03-06 (Tue, 06 Mar 2012) Changed paths: M gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ParameterExpander.java M gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ToGerritRunListener.java M gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/model/BuildMemory.java M gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger.java M gerrithudsontrigger/src/main/resources/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTrigger/config.jelly A gerrithudsontrigger/src/main/webapp/trigger/help-BuildUnsuccessfulFilepath.html M gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ParameterExpanderTest.java M gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ToGerritRunListenerTest.java M gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerTest.java M gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/mock/DuplicatesUtil.java M gerrithudsontrigger/src/test/java/com/sonyericsson/hudson/plugins/gerrit/trigger/mock/Setup.java Log Message: ----------- Merge pull request #12 from jhansche/JENKINS-12881 JENKINS-12881: Allow reading custom build message from a workspace file, in case of non-success Compare: https://github.com/jenkinsci/gerrit-trigger-plugin/compare/c86949f...81f7aea